Open
Conversation
ActivityAlreadyStartedError.__init__ passes "Workflow execution already started" to super().__init__(), which is a copy-paste error from WorkflowAlreadyStartedError. Add a unit test and an assertion in the existing integration test that both fail, demonstrating the bug.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Fix an error message
Why?
It was incorrectly mentioning "Workflow" in an activity error message
Checklist
PR contains a test
Note
Low Risk
Low risk: changes only the user-facing exception message for
ActivityAlreadyStartedErrorand adds a test assertion to prevent regression.Overview
Fixes
ActivityAlreadyStartedErrorto report an activity already started (instead of incorrectly saying workflow already started).Adds a regression check in
test_id_conflict_policy_failensuring the exception string contains "Activity" when an activity ID conflict occurs.Written by Cursor Bugbot for commit 48832d6. This will update automatically on new commits. Configure here.