Fix start_activity() dropping priority parameter#1347
Closed
mfateev wants to merge 2 commits intotemporalio:mainfrom
Closed
Fix start_activity() dropping priority parameter#1347mfateev wants to merge 2 commits intotemporalio:mainfrom
mfateev wants to merge 2 commits intotemporalio:mainfrom
Conversation
The priority parameter was accepted in the function signature but not forwarded to workflow_start_activity(), unlike execute_activity() and start_activity_class() which correctly pass it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Uses the established interceptor pattern: a workflow calls start_activity() with priority=Priority(priority_key=3), a WorkflowOutboundInterceptor captures the StartActivityInput, and the test asserts the captured input has the correct priority. Fails without the fix since start_activity() was silently dropping the priority param. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Development User seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
Odd, I think I fixed this in August: 7e1c725 |
Contributor
|
Yeah you're about 300 commits behind main. |
Member
Author
|
Closing — this bug was already fixed upstream. The fork (mfateev/sdk-python) was stale and didn't have the fix yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start_activity()acceptedpriorityas a parameter but silently dropped it — it was not forwarded toworkflow_start_activity(). Bothexecute_activity()andstart_activity_class()correctly forward it.StartActivityInputviaWorkflowOutboundInterceptorand verifies the priority is present when usingstart_activity().Test plan
test_start_activity_forwards_priority— workflow callsstart_activity()withPriority(priority_key=3), interceptor capturesStartActivityInput, assertsinput.priority == Priority(priority_key=3)test_workflow_prioritiescontinues to pass (usesexecute_activitypath)🤖 Generated with Claude Code