fix: improve swamp-model description with explicit extension-model boundary#811
Merged
fix: improve swamp-model description with explicit extension-model boundary#811
Conversation
…undary
## Summary
- Improve swamp-model skill description to better trigger on method-related
queries (validation, transform, enrichment) while staying scoped to swamp
domain terms. Added concrete definition of what swamp models are: "structured
automation units that define typed schemas, methods, and outputs for data
processing".
- Add explicit boundary with swamp-extension-model: "Do NOT use when the user
wants to build, create, or implement a custom model type, Zod schema, or
TypeScript model — that is swamp-extension-model". This prevents false
triggers on queries like "Build a Zod schema for my custom validation model".
- Fix "Delete this model from the repository" eval expectation from false to
true — `model delete` is explicitly in the skill's trigger keywords.
- Trigger eval: 75% → 81% (passing). Remaining miss ("Run the validation
method on this JSON data") is a zero-context edge case that passes
intermittently with EVAL_RUNS=3.
- tessl review: 91% average (description 82%, content 100%) — passes.
## Test plan
- [x] `EVAL_RUNS=1 deno run eval-skill-triggers --skill swamp-model` — 81%, passes
- [x] `npx tessl skill review .claude/skills/swamp-model` — 91% average
- [x] No false triggers on swamp-extension-model boundary queries
- [x] Negatives all pass except probabilistic variance on EVAL_RUNS=1
🤖 Generated with [Claude Code](https://claude.com/claude-code)
There was a problem hiding this comment.
Adversarial Review
Critical / High
None.
Medium
None.
Low
.claude/skills/swamp-model/evals/trigger_evals.json: The oldnotefor the "Delete this model" entry explained nuance ("borderline; context determines if this is about removing from system vs managing the definition"). The new note ("model delete is a listed trigger keyword") is simpler but loses that nuance. If the eval framework ever uses notes for disambiguation, the reduced context could matter. Practically irrelevant since notes are informational only.
Verdict
PASS — Metadata-only changes to a skill description and eval expectations. The eval fix correctly aligns "Delete this model from the repository" with the skill's explicit "model delete" trigger keyword. No executable code is modified; nothing to break.
There was a problem hiding this comment.
Review: LGTM
Clean, well-scoped skill definition update. No blocking issues.
What changed:
- Improved
swamp-modelskill description with concrete definition ("structured automation units") and expanded trigger keywords (validation method, transform method, enrichment model, etc.) - Added explicit boundary with
swamp-extension-modelto prevent false triggers - Fixed "Delete this model from the repository" eval:
should_triggercorrected fromfalsetotrue—model deleteis clearly listed in the skill's trigger keywords and Quick Reference table
Verified:
- JSON eval file is valid
- YAML frontmatter is well-formed
- Eval expectation change is logically correct — delete is a lifecycle operation covered by this skill
- No TypeScript code changes, so no type/lint/test/import concerns apply
No suggestions — this is a straightforward improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
queries (validation, transform, enrichment) while staying scoped to swamp
domain terms. Added concrete definition of what swamp models are: "structured
automation units that define typed schemas, methods, and outputs for data
processing".
wants to build, create, or implement a custom model type, Zod schema, or
TypeScript model — that is swamp-extension-model". This prevents false
triggers on queries like "Build a Zod schema for my custom validation model".
true —
model deleteis explicitly in the skill's trigger keywords.method on this JSON data") is a zero-context edge case that passes
intermittently with EVAL_RUNS=3.
Test plan
EVAL_RUNS=1 deno run eval-skill-triggers --skill swamp-model— 81%, passesnpx tessl skill review .claude/skills/swamp-model— 91% average🤖 Generated with Claude Code