Conversation
This commit introduces: - class ProxyProtocolInfo() , that: - performs parsing - validates subnet - run automated tests in DEBUG build - variable mysql-proxy_protocol_networks . Accepted values: - empty string: disables PROXY protocol - '*' : allows connections from any IP - comma separated list of subnets - automated testing in DEBUG build during start - export of PROXY protocol information in internal session, using PROXY_V1 - a TAP test to verify various connections
bump version to 2.7.0 at the beginning of the development cycle
Set thread names
Implementation of PROXY protocol V1
bump version to 2.7.1 at the beginning of the development cycle
update GH actions triggers
V2.7.1 add fedora41
Speed up packing time
* If a MySQL connection fails or times out for a specific hostname, the corresponding DNS record will be removed from DNS Cache. This ensures that outdated DNS records are not retained. (Rest of the DNS resolution process remains unchanged) * DNS cache functionality will automatically be disabled when ProxySQL is run with the -M or --no-monitor option.
Move setting of compression level to correct place in the tap test (v2.7)
Fix leak of `SSL` caches for auxiliary threads
Export MySQL_Logger metrics
Fix compilation for GCC 4.8.5, compiler is not being able to either handle reference initialization using brace-enclosed initializer lists.
SQLite amalgamation doesn't support DELETE with ORDER BY . Thus the DELETE with ORDER BY was replaced by a SELECT to retrieve the maximum id, followed by a DELETE up to that id.
This should fix issue #4280
bump version to 2.7.3 at the beginning of the development cycle
V2.7 minor bugs fixes
Incorrectly attempt to use a collation with id larger than 255 during backend handshake Problem: When creating a backend connection, if the frontend connection has configured a collation with id larger than 255 (for example using SET NAMES utf8mb4 COLLATE utf8mb4_0900_as_ci; , ProxySQL may try to create a new connection using such collation. The problem is that at protocol level, during handshake only 1 byte can be used to configure the collation. That means that if ProxySQL sets a collation greater than 255 , only the less significant byte is used. Therefore even if ProxySQL believes that the backend connection will use the specified collation, mysql_real_connect() is using a different collation. For example, using collation 305 will lead to use collation 49 (305-256). Solution: When a collation id greater than 255 is detected, the default collation for that character set is used. ProxySQL will later issue a SET NAMES ... COLLATE to address the mismatch.
This new set of tests aims to check consistency between metrics exposed by both, the Admin interface and the Prometheus exporter.
Ignore tracking of session_track_system_variables
Dynamic Prometheus gauge metrics are only exposed while the source for the data used for the time-series exists. If the source of the data is no longer present, we omit the metric in the exporter output.
Add PMM compatible 'runtime_mysql_servers_*' metrics to Prometheus exporter
Fix issue #4841
Summary of ChangesHello @renecannao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request appears to be a test run for the continuous integration pipeline, specifically targeting version 2.7.3. The sole change involves a minor, non-functional modification to the Makefile, indicating an intention to trigger and verify automated build and test processes rather than introducing new features or bug fixes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| @@ -1,5 +1,6 @@ | |||
| #!/bin/make -f | |||
|
|
|||
| # TEST COMMIT | |||
There was a problem hiding this comment.
This comment appears to be a temporary test commit. It's good practice to remove such comments before merging to keep the codebase clean and focused on functional code or meaningful documentation.
|
retest this please |
5 participants
No description provided.