Solr themebrowser #207
Open
Solr themebrowser #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Backport the index fields from the old deployment. - No test changes, because no test coverage on this view at all. This is just a dirty MVP checkpoint. It works but the schema needs cleaning up.
Also: provide upgrade, adjust tests
Filter on portal root to avoid Unauthorized
... checkpoint where it at least doesn't error out.
To do: - Suppress faceting links resulting in 0 matches - Javascriptified expand/collapse of browsing menu
TODO: propagate facets to search form (propagating search to facet menu already works)
Collaborator
Author
|
Note that the commit list is long because it includes commit from the |
pilz
approved these changes
Nov 14, 2025
Member
pilz
left a comment
pilz
left a comment
There was a problem hiding this comment.
The facet search works fine as described.
Collaborator
Author
|
Reviewed Alex's changes, lookin good but needs further attention in the debarbonization and cleanup. Before we merge this, I first want to validate that we want to keep the work I did on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs https://github.com/syslabcom/scrum/issues/3149
This branch builds on the faceted search implementation that was staged before. We may want to remove that work and use the previously provided search instead. (Because the theme browser is independent from the search view).
Features:
Solr based faceting browser as layout on themen-epochen-regionen
Added search input there
Seems to be pretty fast
Facet narrowing, including suppression of facet criteria that would result in an empty result set, is all handled in backend code that closely matches the old code
Main code changes versus the old implementation derive from replacing filter expressions with list generators
I removed SearchableText as a stored index for speed (and also ObjectProvides but that's not yet reflected in the running solr schema).
Constraints:
No JS collapsing/expanding of submenus. The old JS code depends on jQuery. I've looked at pat-depends but that's not valid for this use case.
Searching for text, then narrowing on facets, works. But narrowing on facets, then adding or changing Searchable Text, resets the facets. I've worked on keeping the facets but realized that is invalid from a UX perspective: it may result in an empty result set. In which case you then need a new affordance to reset the facets.
Not yet done / future work:
The search view I applied from collective.solr is suboptimal. Porting the old search view, or improving this one, is todo.
I tried to rip out eea.facetednavigation but plenty of other views depend on that.
Those views should be redone as part of the Decarbonize 2 ticket.
I have not set up Solr boosting or tuned Solr for performance yet.