Skip to content

fix: default to rune mode#952

Open
sacrosanctic wants to merge 7 commits intosveltejs:mainfrom
sacrosanctic:equal-spider
Open

fix: default to rune mode#952
sacrosanctic wants to merge 7 commits intosveltejs:mainfrom
sacrosanctic:equal-spider

Conversation

@sacrosanctic
Copy link
Contributor

closes #944

@changeset-bot
Copy link

changeset-bot bot commented Feb 27, 2026

🦋 Changeset detected

Latest commit: f2d7731

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 27, 2026

Open in StackBlitz

npx https://pkg.pr.new/svelte-migrate@952
npx https://pkg.pr.new/sv@952
npx https://pkg.pr.new/@sveltejs/sv-utils@952

commit: b29b2b0

@sacrosanctic
Copy link
Contributor Author

why doesnt the snapshots fail?

@jycouet
Copy link
Contributor

jycouet commented Feb 27, 2026

why doesnt the snapshots fail?

These files are not used (I mean, not in creation)
The idea originally was to be able to start these template directly in the repo.

You should probably tune these packages/sv/src/create/shared/**/svelte.config.js

@sacrosanctic
Copy link
Contributor Author

These files are not used (I mean, not in creation)

That's confusing, can we not do that. They're not real repos.

@svelte-docs-bot
Copy link

@jycouet
Copy link
Contributor

jycouet commented Feb 28, 2026

These files are not used (I mean, not in creation)

That's confusing, can we not do that. They're not real repos.

I'm torn on this one. Yes, they are not real repos... But it's kinda nice to be able to start it, tweak it and save the update.
At the same time, since we do a lot of replacement, it's probably not that usefull!
I think I would like also to tweak a bit the strategy and have a created hook.
This should probably be part of another PR anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should legacy mode be explained in the tutorial?

2 participants