Conversation
palmer-cl
commented
Mar 18, 2026
palmer-cl
commented
- Update tracked changes to allow for diacritical symbols in tracked changes
- add behavior tests
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c7c2170113
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
packages/super-editor/src/extensions/track-changes/trackChangesHelpers/trackedTransaction.js
Show resolved
Hide resolved
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@palmer-cl good idea letting composition through so accented characters get tracked — that part works.
one bug found during testing: typing an accented character with a dead key (like Option+E then E for é) leaves a stray ' before the accent and breaks Enter afterward (adds spaces instead of new lines). the existing tests don't catch this because they simulate composition differently than how the browser actually does it.
left an inline comment with details.
packages/super-editor/src/extensions/track-changes/trackChangesHelpers/trackedTransaction.js
Show resolved
Hide resolved
…racters-with-diacritical-symbols-do-not-render-as-tcs
…k changes functionality
…racters-with-diacritical-symbols-do-not-render-as-tcs
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@palmer-cl the space+accent fix from round 1 is working. one thing left: accents at paragraph start in suggesting mode still break. left an inline comment with what I found.
| } | ||
|
|
||
| if (shouldForceEndStaleComposition(view, event)) { | ||
| __endComposition(view); |
There was a problem hiding this comment.
in suggesting mode, typing an accent at the start of a paragraph produces 'e instead of é. the shouldForceEndStaleComposition guard seems to be ending the composition too early — the final character arrives without the accent.
from what I can tell, the tracked changes transaction rebuild makes the composition look stuck when it's still active. pendingDeadKeyPlaceholder might be a good signal to distinguish real stale compositions from this case. also worth checking if ˜ (U+02DC) needs to be added to the placeholder map — some keyboards use it instead of ~.
tested in the dev app with debug logging on shouldForceEndStaleComposition and normalizeCompositionInsertStep.
2 participants
