fix: popover menu renders at correct position in presentation mode#1725
Draft
caio-pizzol wants to merge 4 commits intomainfrom
Draft
fix: popover menu renders at correct position in presentation mode#1725caio-pizzol wants to merge 4 commits intomainfrom
caio-pizzol wants to merge 4 commits intomainfrom
Conversation
Contributor
Author
|
@harbournick this is still in draft - but do you think this is the "correct" path for fixing Popover Extension? (when @ mentioning someone) |
caio-pizzol
force-pushed
the
caio/sd-1477-popovermentions-menu-renders-off-screen-in-presentation-mode
branch
from
0f081ff to
8998d31
Compare
Replace getViewportCoordsFromPainterHost with editor.coordsAtPos() which delegates to PresentationEditor.coordsAtPos() in presentation mode. This handles all node types, zoom, and scroll via the layout engine instead of fragile CSS class-based DOM scraping.
Hide tippy when coordsAtPos returns null to prevent stale popover position. Rename inserMention to insertMention across popover-plugin and Mentions.vue.
caio-pizzol
force-pushed
the
caio/sd-1477-popovermentions-menu-renders-off-screen-in-presentation-mode
branch
from
8998d31 to
c4bbc37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.