Draft
Conversation
Contributor
|
We will use the "PythonLaurelCorePrelude" in this PR #489 for Python-> Laurel translation instead of the "CorePrelude". |
Contributor
Author
Yes, this PR conflicts with that one, but I think that's OK we can resolve the conflicts. I don't mind resolving them in whatever PR gets merged last. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
CorePrelude.leanwithPythonPreludeInLaurel.leanCaveat, there is still a
CorePreludeForLaurel.leanfile as well. This is needed to hold axioms that Python requires in Core. Laurel does not support axioms so using a separate Core file is a good workaround. A long term solution would be that the Python pipeline stops relying on axioms.Caveat2, because DDM parsing also does a form of resolution,
CorePreludeForLaurel.leanneeds a lot of type definitions that are already provided inPythonPreludeInLaurel.lean. Ideally we'd find a way so that's no longer necessary, using something like#strata_parsing_onlyCaveat3, two procedures have been left in
CorePreludeForLaurel.leanbecause their contracts contain labelled requires/ensures and Laurel does not support that. I'm not sure whether we should add support for that. I think this can be made obsolete by having traces for failed assertions.Tested