fix: Specify argument in Client "error" event to be Error instead of any. #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Taureon wants to merge 1 commit into stoatchat:main from Taureon:patch-1

+1 −2

Taureon commented Feb 12, 2026

I don't see a reason for this to be any, so I am updating this to be an Error instead for the type system.

Only location where the "error" event was emitted (I think):

javascript-client-sdk/src/Client.ts

Line 263 in cdf4060

this.events.on("error", (error) => this.emit("error", error));

Callback argument type where that "error" event comes from:

javascript-client-sdk/src/events/EventClient.ts

Line 70 in cdf4060

error: [error: Error];


          Client.ts: change Events.error callback argument from any to Error

4e25a1b

Only location where the "error" event was emitted:
https://github.com/stoatchat/javascript-client-sdk/blob/cdf406094b9b81c3ff285b14ed97fb3d138e3061/src/Client.ts#L263

Callback argument type where that "error" event comes from:
https://github.com/stoatchat/javascript-client-sdk/blob/main/src/events/EventClient.ts#L70

Signed-off-by: Taureon <45183108+Taureon@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet