(closes #279) Remove Arguments.dofs and generally improve code coverage

[sergisiso]

No description provided.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (470e0f7) to head (acbc434).
⚠️ Report is 19 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3258      +/-   ##
==========================================
+ Coverage   99.91%   99.95%   +0.04%     
==========================================
  Files         376      376              
  Lines       53522    53485      -37     
==========================================
- Hits        53477    53463      -14     
+ Misses         45       22      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sergisiso]

@arporter This is ready for review. It brings the codecov misses from 45 to 27 and adds no-cover pragmas to the remaining (maybe you know how to do better in the remaining?). I also added a more strict reporting for deleted lines (indirect changes).

[arporter]

Thanks very much for tackling this Sergi.
There are a couple of cases where I think we can add tests rather than no-cover pragmas. Also, you've removed some validation code from ACCEnterDataTrans and I don't understand why.

[sergisiso]

@arporter This is ready for another look.

[arporter]

Thanks Sergi. Apart from the need to put back (or discuss) the check for different asynch. queues in EnterData, this is pretty much ready to go now. I see the integration tests were all OK previously so won't re-run them now.

[sergisiso]

I reverted the controversial change and removed #3250 from the list of issues that the PR will close since finally it doesn't reach 100% coverage and I still want to look to the remaining lines at some point.

Ready for another look @arporter

[arporter]

All looks good now, thanks Sergi.
As master has now moved on, I'll re-run the IT and then proceed to merge.

[arporter]

IT were all green. I'll update the changelog and proceed to merge.