feat(fennel): add fennel support #498
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevearc
requested changes
Dec 14, 2025
Owner
stevearc
left a comment
stevearc
left a comment
There was a problem hiding this comment.
Thanks for the PR! Left a couple of questions/suggestions
Comment on lines
+407
to
+423
| M.fennel = { | ||
| postprocess = function(bufnr, item, match) | ||
| local node = node_from_match(match, "symbol") | ||
| local full_form = get_node_text(node, bufnr) | ||
|
|
||
| if item.kind == "Function" then | ||
| local name = string.match(full_form, "[λ fn lambda macro] (%S+) %[") | ||
| item.name = name ~= nil and name or "<Anonymous>" | ||
| elseif item.kind == "Class" or item.kind == "Struct" then | ||
| local kind = (item.kind == "Class") and "local" or "var" | ||
| local query = kind .. " (%S+)" | ||
| local name = string.match(full_form, query) or "<parse error>" | ||
| item.name = name | ||
| else | ||
| item.name = "<parse error>" | ||
| end | ||
| end, |
Owner
There was a problem hiding this comment.
Instead of using these extensions to extract the name, could you just adjust the treesitter queries? The @name capture group can be used to select the node that contains the name.
Comment on lines
+10
to
+14
| (local_form | ||
| (#set! "kind" "Class")) @symbol @root | ||
|
|
||
| (var_form | ||
| (#set! "kind" "Struct")) @symbol @root |
Owner
There was a problem hiding this comment.
Do Struct and Class make sense for these? I would assume that this more naturally maps to the Variable type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Love the project!
I added fennel support for locals/vars and then function-like forms (lambdas, fns and macros), as well as tests.
Feedback is welcome