Carcosa Element #2592
Open
Carcosa Element #2592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update Makefile.am to include impl file fix serialization to stop compiler errors and warnings
build parameter reader for fault type add parameter for choosing fault type add parameter for stuckAtFault inputs
…tly skeletoned, but I will add the rest soon
…class--need to fix some compiler issues and skeletonize the other faults
…w to determine message direction
…'s still no dynamic way to change what fault logic is in use
compiler is giving me errors that the exact same code didn't give in the last fault--will test when this is resolved
randomDrop prototype complete--untested
need to refine other aspects (such as payload printing)
add debug output to event dropper need to compare event drop logic to scott's portmodule example (just to make sure I'm not breaking anything on accident)
need to do 2 things: 1. change fault** into vec[fault*] and rewrite affected code 2. figure out better way to pass valid installation directions to injectors
must implement serialization for FaultBase class after this is done, I can finally go in and fix the faulty logic in the StuckAtFault and CorruptMemRegion classes
Still todo: 1. Refine stuckAtFault debug prints to make more sense 2. Refine address selection in stuckAtFault and corruptMemFault to only corrupt the valid range of data
stuckAtFault debug output should be fixed, and it now properly accounts for endianness in the data array FaultBase debug outputs for setMemEventPayload improved need to take a look at corrupt mem next, and run some more tests on stuck at
…with other members begin fix for corruptMemRegion - No longer crashes simulation - Should be more optimized to only run on smaller regions of code that actually need changes instead of looping through everything every time - Currently crashes when hitting assertion for start index of corrupt message when two regions are in the same message but don't overlap
Todo: - Build test configs for each included fault and get them into the testing system
rng hooks in FaultInjectorBase expanded to include every usage without later faults or injectors needing their own need to figure out how to delay injection so that it doesn't occur when sst initialization is still occurring
Contributor
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Carcosa Element to SST Elements
Features
Known Issues
Planned Updates