Skip to content

Restrict volume parent directory validation to Linux#30

Merged
srichs merged 1 commit intomainfrom
codex/fix-failing-ci-tests
Feb 8, 2026
Merged

Restrict volume parent directory validation to Linux#30
srichs merged 1 commit intomainfrom
codex/fix-failing-ci-tests

Conversation

@srichs
Copy link
Owner

@srichs srichs commented Feb 8, 2026

Motivation

  • Prevent unnecessary parent-directory existence checks during volume creation on Windows and macOS so platform-specific behaviors (macOS placeholder creation and Windows format tool behavior) work as expected.

Description

  • Modify create_volume in src/veracrypt/veracrypt.py to call _validate_volume_parent_dir(volume_path) only when self.os_name == "Linux", keeping macOS and Windows behavior unchanged.

Testing

  • Ran pytest -q and all tests passed: 42 passed in 0.11s.

Codex Task

@srichs srichs merged commit cd1f4e8 into main Feb 8, 2026
2 checks passed
@srichs srichs deleted the codex/fix-failing-ci-tests branch February 8, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant