Conversation
akandic47
requested review from
MakMuftic,
mpetrun5,
mpetrunic and
tcar121293
as code owners
|
Go Test coverage is 53.7 %\ ✨ ✨ ✨ |
|
Go Test coverage is 53.7 %\ ✨ ✨ ✨ |
mpetrunic
left a comment
mpetrunic
left a comment
There was a problem hiding this comment.
Isn't the whole point of opentelemetry that you can pipe it into prometheus without changing the code?
| meterOpts = append(meterOpts, sdkmetric.WithReader(promExporter)) | ||
| } | ||
|
|
||
| mp, err := observability.InitMetricProvider(context.Background(), configuration.RelayerConfig.OpenTelemetryCollectorURL, meterOpts...) |
There was a problem hiding this comment.
| mp, err := observability.InitMetricProvider(context.Background(), configuration.RelayerConfig.OpenTelemetryCollectorURL, meterOpts...) | |
| mp, err := observability.InitMetricProvider(ctx, configuration.RelayerConfig.OpenTelemetryCollectorURL, meterOpts...) |
|
|
||
| mp, err := observability.InitMetricProvider(context.Background(), configuration.RelayerConfig.OpenTelemetryCollectorURL) | ||
| var meterOpts []sdkmetric.Option | ||
| if configuration.RelayerConfig.PrometheusEnabled { |
There was a problem hiding this comment.
I don't think we even need the option.
There is really no reason to turn it off.
There was a problem hiding this comment.
You mean to turn off prometheus endpoint?
It is if you deploy the collector. |
| CoinmarketcapConfig CoinmarketcapConfig | ||
| SolverConfig SolverConfig | ||
| ApiAddr string | ||
| PrometheusEnabled bool |
There was a problem hiding this comment.
There is an OpentelemetryCollectorURL variable which we are not using.
This doesn't make sense from the standpoint that it will still try to push to the collector, but printout logs that it fails (that is what currently happens).
Yeah I am trying to avoid running more infra stuff only because of this. All other metrics are being scraped by prometheus directly |
|
Go Test coverage is 53.7 %\ ✨ ✨ ✨ |
|
Closing as Prometheus exposes collector directly |
3 participants
Description
Related Issue Or Context
Closes: #
How Has This Been Tested? Testing details.
Types of changes
Checklist: