Remove pkg_resources
#3351
Remove pkg_resources
#3351
Conversation
|
@dlstadther I think this PR looks good. Can you please take a look |
|
Great job! As alternative solution, we can replace deprecated API calls with
|
dlstadther
left a comment
dlstadther
left a comment
There was a problem hiding this comment.
While this can work, i'd prefer seeing the deprecated API calls replaced. The less dependencies, the better.
dlstadther
left a comment
dlstadther
left a comment
There was a problem hiding this comment.
Looks good! Thanks for making this change and for identifying/fixing our issue with 3.12 support!
|
@RRap0so , could we update merge rules to not require that |
|
|
||
| def get_template_path(self): | ||
| return pkg_resources.resource_filename(__name__, 'templates') | ||
| return importlib.resources.files("templates").name |
There was a problem hiding this comment.
@dlstadther this change caused coverage to fail. Not sure why this is happening since this is an existing function. Do you know where would be a good place to add a test for this?
There was a problem hiding this comment.
I just saw your other comment.
There was a problem hiding this comment.
The tests for server.py live in https://github.com/spotify/luigi/blob/master/test/server_test.py . It looks like multiple of these "Handler" classes are currently untested.
This PR adds setuptools to pyproject.toml
|
Hi team, do you plan on merging this PR? I am using luigi with python 3.13. Currently I am using pip to install setuptools in order to get luigid to start. I see this warning: So I am wondering if can expect this PR to be merged or if I should roll back to an earlier python (or setuptools) version. Thank you. |
|
@alexeiverbny This project has fallen off my radar. I see that this PR's last CI failed tests. I'm not sure what has happened since then, but it appears that I no longer have permissions to rerun the Github Actions pipelines like i used to. The latest changes LGTM, i'd just like to see the test suite succeed. |
4 participants
Description
luigidfails to start in Python 3:12 due to missing setuptools.Motivation and Context
Fix #3350
Have you tested this? If so, how?
Yes. I installed this code on a fresh virtual environment with the following:
And the issue is resolved.
lugidstarts without issues