Fix pre-release bundle target after Helm CRD removal#1722
Fix pre-release bundle target after Helm CRD removal#1722gabrielm-splunk merged 3 commits intodevelopfrom
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Pull request overview
This PR updates the build workflow to reflect that the splunk/splunk-operator Helm chart no longer includes CRDs, preventing make bundle (and pre-release workflows) from failing due to a missing Helm CRD directory.
Changes:
- Removed the stale CRD copy step from the
bundletarget in theMakefile. - Removed the related outdated comment describing CRD copying into the Helm chart.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gabrielm-splunk
left a comment
There was a problem hiding this comment.
Thanks for addressing this
|
Seems you need to comment: |
|
recheck |
|
I have read the Code of Conduct and I hereby accept the Terms |
9f15aac to
e4cd5b7
Compare
|
I have read the Code of Conduct and I hereby sign the COC |
|
recheck |
|
I have read the CLA Document and I hereby sign the CLA |
|
Coveralls still seems down, but we can add the: |
|
I have read the Code of Conduct and I hereby accept the Terms |
|
I have read the CLA Document and I hereby sign the CLA+ |
760db63 to
d9eaecb
Compare
Description
Removes the stale CRD copy operation from
make bundleso pre-release workflow runs do not fail after CRDs were removed from thesplunk/splunk-operatorHelm chart.Key Changes
Makefilecp bundle/manifests/enterprise.splunk.com* helm-chart/splunk-operator/crdsfrombundletarget.Testing and Verification
make -n bundle IMAGE_TAG_BASE=docker.io/splunk/splunk-operator VERSION=3.1.0 IMG=docker.io/splunk/splunk-operator:3.1.0 SPLUNK_ENTERPRISE_IMAGE=docker.io/splunk/splunk:10.2.0helm-chart/splunk-operator/crds.docs/Helm.mdstatessplunk/splunk-operatorchart no longer contains CRDs and CRDs must be installed separately.Related Issues
22364043135, job64725104365wheremake bundlefailed due to missinghelm-chart/splunk-operator/crdspath.PR Checklist