Skip to content

Fix pre-release bundle target after Helm CRD removal#1722

Merged
gabrielm-splunk merged 3 commits intodevelopfrom
fix/remove-stale-crd-copy-step
Feb 26, 2026
Merged

Fix pre-release bundle target after Helm CRD removal#1722
gabrielm-splunk merged 3 commits intodevelopfrom
fix/remove-stale-crd-copy-step

Conversation

@vivekr-splunk
Copy link
Collaborator

Description

Removes the stale CRD copy operation from make bundle so pre-release workflow runs do not fail after CRDs were removed from the splunk/splunk-operator Helm chart.

Key Changes

  • Makefile
  • Removed cp bundle/manifests/enterprise.splunk.com* helm-chart/splunk-operator/crds from bundle target.
  • Removed the outdated comment that said generated CRDs are copied into Helm chart CRD directory.

Testing and Verification

  • Ran dry-run of bundle target:
    • make -n bundle IMAGE_TAG_BASE=docker.io/splunk/splunk-operator VERSION=3.1.0 IMG=docker.io/splunk/splunk-operator:3.1.0 SPLUNK_ENTERPRISE_IMAGE=docker.io/splunk/splunk:10.2.0
  • Verified dry-run no longer includes any copy into helm-chart/splunk-operator/crds.
  • Confirmed docs alignment:
    • docs/Helm.md states splunk/splunk-operator chart no longer contains CRDs and CRDs must be installed separately.

Related Issues

  • Fixes failure in pre-release workflow run 22364043135, job 64725104365 where make bundle failed due to missing helm-chart/splunk-operator/crds path.

PR Checklist

  • Code changes adhere to the project's coding standards.
  • Relevant unit and integration tests are included.
  • Documentation has been updated accordingly.
  • All tests pass locally.
  • The PR description follows the project's guidelines.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2026

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the build workflow to reflect that the splunk/splunk-operator Helm chart no longer includes CRDs, preventing make bundle (and pre-release workflows) from failing due to a missing Helm CRD directory.

Changes:

  • Removed the stale CRD copy step from the bundle target in the Makefile.
  • Removed the related outdated comment describing CRD copying into the Helm chart.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@gabrielm-splunk gabrielm-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this

@gabrielm-splunk
Copy link
Collaborator

Seems you need to comment:
I have read the Code of Conduct and I hereby accept the Terms
and
I have read the CLA Document and I hereby sign the CLA

@vivekr-splunk
Copy link
Collaborator Author

recheck

@vivekr-splunk
Copy link
Collaborator Author

vivekr-splunk commented Feb 25, 2026

I have read the Code of Conduct and I hereby accept the Terms

@vivekr-splunk vivekr-splunk force-pushed the fix/remove-stale-crd-copy-step branch from 9f15aac to e4cd5b7 Compare February 25, 2026 13:55
@vivekr-splunk
Copy link
Collaborator Author

I have read the Code of Conduct and I hereby sign the COC

@vivekr-splunk
Copy link
Collaborator Author

recheck

@vivekr-splunk
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@gabrielm-splunk
Copy link
Collaborator

Coveralls still seems down, but we can add the:
fail-on-error: false
option to the workflow yamls as suggested by the coveralls status page

@vivekr-splunk
Copy link
Collaborator Author

I have read the Code of Conduct and I hereby accept the Terms

@vivekr-splunk
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA+

@vivekr-splunk vivekr-splunk force-pushed the fix/remove-stale-crd-copy-step branch from 760db63 to d9eaecb Compare February 25, 2026 20:24
@gabrielm-splunk gabrielm-splunk merged commit 76f6658 into develop Feb 26, 2026
31 checks passed
@gabrielm-splunk gabrielm-splunk deleted the fix/remove-stale-crd-copy-step branch February 26, 2026 01:57
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants