Call callbacks in batch logging scenario once the request is sent or failed.#33
Open
bosjgt wants to merge 2 commits intosplunk:developfrom
Open
Call callbacks in batch logging scenario once the request is sent or failed.#33bosjgt wants to merge 2 commits intosplunk:developfrom
bosjgt wants to merge 2 commits intosplunk:developfrom
Conversation
…a callback even in a batch logging scenario
|
Hi @bosjgt, Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if the logger is configured for batch messaging, the callback for the send call is not being invoked except for messages that cause the batch limit to be reached.
For context: This is currently causing a problem trying to create a transport for winston to connect logs to splunk when configuring this library to use batch sending. Since the initial callback is never invoked, only one log message will ever get sent.
This code change retains a reference to the callbacks for every message that is queued up, so that once the request is complete or fails, every message's callback that was sent or failed to send is invoked.