-
Notifications
You must be signed in to change notification settings - Fork 0
Feature kpoland dataset new version #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
klpoland
wants to merge
16
commits into
master
Choose a base branch
from
feature-kpoland-dataset-new-version
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
30124a1
move views an template updates over
klpoland fa192f4
add versioning manager in js, consolidate modal hooks
klpoland fb8fc78
add previous version, version char to int
klpoland e8ea958
add views, serializer field, template updates
klpoland 82f33e1
restructure dataset list view/template for refreshing
klpoland 6ebfe2a
refactor modal refs and list refreshing, clean up event listeners, bu…
klpoland 81951e3
save new dataset version first
klpoland 80324ee
add version to dataset editor
klpoland 0c1c041
pre-commit fixes
klpoland fb807c4
re-order migrations
klpoland cb29350
fix migration bugs, modal display issues
klpoland 40008c2
update jest tests
klpoland 5511b8d
address comments
klpoland 66323b2
add keyword url back
klpoland fc0eadb
move keyword autocomplete JS class to dedicated file
klpoland 0b79b4c
add tests
klpoland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
33 changes: 33 additions & 0 deletions
33
...sds_gateway/api_methods/migrations/0020_dataset_previous_version_alter_dataset_version.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # Generated by Django 4.2.26 on 2025-11-25 20:50 | ||
|
|
||
| from django.db import migrations, models | ||
| import django.db.models.deletion | ||
|
|
||
| def convert_version_to_integer(apps, schema_editor): | ||
| """Convert empty string versions to 1 before changing field type.""" | ||
| Dataset = apps.get_model('api_methods', 'Dataset') | ||
| # Update all datasets with empty or invalid version strings to default value of 1 | ||
| for dataset in Dataset.objects.all(): | ||
| if not dataset.version or dataset.version.strip() == '': | ||
| dataset.version = '1' | ||
| dataset.save(update_fields=['version']) | ||
|
|
||
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ('api_methods', '0019_capture_datasets_file_captures_file_datasets_and_more'), | ||
| ] | ||
|
|
||
| operations = [ | ||
| migrations.AddField( | ||
| model_name='dataset', | ||
| name='previous_version', | ||
| field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.PROTECT, related_name='next_version', to='api_methods.dataset'), | ||
| ), | ||
| migrations.RunPython(convert_version_to_integer, migrations.RunPython.noop), | ||
| migrations.AlterField( | ||
| model_name='dataset', | ||
| name='version', | ||
| field=models.IntegerField(default=1), | ||
| ), | ||
| ] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 0019_capture_datasets_file_captures_file_datasets_and_more | ||
| 0020_dataset_previous_version_alter_dataset_version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The migration timestamp indicates a future date: "2025-11-25 20:50". This appears to be incorrect as the current date context indicates it's February 2, 2026. Migration timestamps should reflect when they were actually generated. This should be updated to the correct date when the migration was created.