-
Notifications
You must be signed in to change notification settings - Fork 40
Bring changes from v7.11.4 to main
#7683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… when building a case statement for the QB.
emenslin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Save the Data Entry record and ensure the record saves successfully
- Reload the page and ensure Specify loads and still remains accessible
- Save the Data Entry record and ensure the record saves successfully
- Ensure that the value for the autonumbered field from Data Entry is skipped in the WorkBench upload results.
- Save the Data Entry record and ensure the record saves successfully
- Ensure that the value for the autonumbered field from Data Entry is skipped in the WorkBench upload results.
- Save the Accession and ensure the record saves successfully
- Ensure that the Accessions in different Divisions are independently auto-numbered (e.g., Accessions in different Divisions should not share the same autonumbering)
- Save the Accession and ensure the record saves successfully
- Ensure that the value for the autonumbered field from Data Entry is skipped in the WorkBench upload results in the other Division
- Generally ensure that autonumbering respects the scoping of Accessions (e.g, using DataEntry, create Accessions in different scopes and ensure they're autonumbered as expected)
Looks good! I did run into some migration problems, but since that could be a test panel issue I will approve this, but it is something that should probably be looked into.
bhumikaguptaa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Save the Data Entry record and ensure the record saves successfully
- Reload the page and ensure Specify loads and still remains accessible
- Save the Data Entry record and ensure the record saves successfully
- Ensure that the value for the autonumbered field from Data Entry is skipped in the WorkBench upload results.
- Save the Data Entry record and ensure the record saves successfully
- Ensure that the value for the autonumbered field from Data Entry is skipped in the WorkBench upload results.
- Save the Accession and ensure the record saves successfully
- Ensure that the Accessions in different Divisions are independently auto-numbered (e.g., Accessions in different Divisions should not share the same autonumbering)
- Save the Accession and ensure the record saves successfully
- Ensure that the value for the autonumbered field from Data Entry is skipped in the WorkBench upload results in the other Division
- Generally ensure that autonumbering respects the scoping of Accessions (e.g, using DataEntry, create Accessions in different scopes and ensure they're autonumbered as expected)
Everything worked as expected! I also came across a few migration errors while testing for the accession auto-numbering.
Brings the changes from #7671 /
v7.11.4tomain.Checklist
self-explanatory (or properly documented)
Testing instructions
Follow the testing instructions from Prevent broken transactions when autonumbering (#7671) (provided below) and ensure the functionality is correct with the updated branch:
Sample Database
To speed up setup for testing this Pull Request, i've set up a testing database that contains all resources required for testing:
Feel free to use the database!
Where Accessions are scoped to Division:
issue-6490_scoped_accession_testing.sql.zip
Where Accessions are globally scoped:
issue-6490_global_accession_testing.sql.zip
General Concurrency with WorkBench
Concurrent Autonumbering with the WorkBench
Concurrent Autonumbering with Non Collection Scoping
Review Table Scoping Hiearchy for an overview on table scopes
With the Sample Database, this would be using the Locality Data Set in the Plants Collection with creating a new Locality in the Vascular Plants Collection
Autonumbering with Variable Table Scoping
In a database with more than one Division where Accessions are scoped to Division
In a database with more than one Division where Accessions are globally scoped
Start a WorkBench Upload operation on a sufficiently large Accession Data Set (the operation needs to be in process while some of the below steps of Concurrent Autonumbering with Non Collection Scoping are completed) where a field on Accession is being autonumbered
Open Specify in a new tab, window, or browser
Switch to a different Collection which is in a different Division as the records being uploaded
Open an Accession DataEntry form
Save the Accession and ensure the record saves successfully
Wait for the WorkBench Upload operation to complete
Ensure that the value for the autonumbered field from Data Entry is skipped in the WorkBench upload results in the other Division
Generally ensure that autonumbering respects the scoping of Accessions (e.g, using DataEntry, create Accessions in different scopes and ensure they're autonumbered as expected)
General