-
Notifications
You must be signed in to change notification settings - Fork 40
Consolidate Setup Tool, Configuration Tool, and Preloaded Tree Creation #7674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@grantfitzsimmons
I haven't been able to recreate this, if its not varying times from downloading trees of different sizes then it may be a worker-related issue. I'll try to investigate if this keeps on happening.
For technical reasons adding the name would complicate the implementation of the cancel button (The only identifying feature of the background task is its id). If time permits I may be able to fix this.
It looks like collection deletion is a little too easy. Some restrictions were removed to allow deleting empty collections in the Configuration Tool PR, we perhaps need to discuss how to add back in some guard rails |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Setup Flow
- All setup forms must display correctly in both light mode and dark mode (based on system settings).
- Users can only progress to the next form once all required fields are completed.
- User selections must be reflected in the Overview sidebar in real time.
- The setup flow must be submittable at the end.
- Users must be able to log into the database after setup completes.
- Default schema configuration captions and descriptions must be populated (not blank).
- Default picklists must be created correctly.
- Note: The Agent Type picklist does not exist in the schema config, this is expected.
- Default preparation types must be created correctly.
- All tree viewer pages must load without errors.
- The admin user’s agent must be created correctly and must always include a last name.
- An empty Global Preferences file must be created in App Resources.
2. Tree Configuration During Setup
Storage Tree
- Users must be able to modify the storage tree configuration during setup.
- Changes must be correctly reflected in the application after setup.
Geography Tree
- Users must be able to modify the geography tree configuration during setup.
- Both options must work:
Preloaded tree
Empty treeTaxon Tree
- Users must be able to select a preloaded default tree when one exists.
- The selected tree must be correctly preloaded and visible when the app opens.
Geology Discipline
- Relevant tectonic and chronostratigraphic (chrono) trees must be created automatically.
If you pre-populate the tree from Mineral taxonomy, it does not use the ranks configured in the default tree, but rather does not populate it at all.
The issue is that 'Geology' encompasses far more than minerals, so if we were to simply define taxon_geology_tree.json with those two ranks, it wouldn't work for the other defaults. Can we handle this case?
I would prefer to use the default ranks instead of the discipline ranks if we're pre-populating?
Once I'm in the app, I can simply add the missing ranks. It would be nice for this to be automatic if chosen during the guided setup:
I pushed a change to make the button styles consistent.
3. Tree Viewer: Preloaded & Empty Trees
- Users can create an empty tree from the tree viewer.
- Users can modify rank configuration in the tree viewer.
- Users can create a preloaded tree from the tree viewer.
- Empty trees now have an upload button. The Upload Tree icon under root creation must work as expected.
I added clarifying labels to these buttons so users aren't confused what the 3rd plus icon on the page means:
- Users can delete a rank with no associated nodes.
- If ranks are deleted and a tree is then loaded, the tree configuration must be respected.
- Users receive notifications for:
Tree creation start
Successful completion
Errors or cancellation4. Configuration Tool
Institution Tree Viewer
- Users can click and drag to view all nodes in the institution tree.
- Clicking a resource node opens the resource form.
- Users cannot create a discipline with a discipline name that is already in use.
- Users can:
- Edit a resource
- Create new resources
- Delete collections (created in 7)
- Users cannot create collections through the subview in a discipline form.
- Users can collapse and expand sections in the left panel.
- Users can switch between vertical and horizontal views in the institution tree viewer.
I also think the collection creation dialog should more closely mimic the guided setup process (with the preview of the format):

Fixed 👍 It now automatically creates missing ranks.
We decided to address this in a future update. |
Fixes #7673
See issue description
(Cloned from #6671)