Fixes APIs to match what they should be doing#1441
Open
MathMan05 wants to merge 1 commit intospacebarchat:masterfrom
Open
Fixes APIs to match what they should be doing#1441MathMan05 wants to merge 1 commit intospacebarchat:masterfrom
MathMan05 wants to merge 1 commit intospacebarchat:masterfrom
Conversation
Comment on lines
-109
to
+113
| if (("bio" in body || "avatar" in body) && req.params.member_id != "@me") { | ||
| if (("bio" in body || "avatar" in body) && member_id != req.user_id) { |
Member
There was a problem hiding this comment.
is this something we really want? Normally its only nicknames...
Contributor
Author
There was a problem hiding this comment.
Like are you asking if the change is needed or if we want to keep this around?
Member
There was a problem hiding this comment.
this changes behavior, normally you cna only patch someone's nickname, not other fields
do we want this?
Contributor
Author
There was a problem hiding this comment.
This does not change behavior, it just corrects the code to check for both ways of modifying your own profile, either by @me or your own id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix some APIs to better match how they should work