-
Notifications
You must be signed in to change notification settings - Fork 61
feat!: Yolo object detection #987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benITo47
wants to merge
8
commits into
main
Choose a base branch
from
@bo/yoloObjectDetection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+592
−88
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
42aaf02
feat: Add multimethod handling to ObjectDetection
benITo47 9b77da7
Update docs
benITo47 9ac45d9
Fix type signatures after rebase
benITo47 4e64116
Fix inproper rebase merge
benITo47 f327983
Update packages/react-native-executorch/common/rnexecutorch/models/ob…
msluszniak 256953e
Update packages/react-native-executorch/common/rnexecutorch/models/ob…
msluszniak 03fcc83
chore close brakets
msluszniak f83b8ad
Apply suggestions from code review
msluszniak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,11 +43,21 @@ processing. Resizing is typically fast for small images but may be noticeably | |
| slower for very large images, which can increase total time. | ||
| ::: | ||
|
|
||
| :::warning | ||
| Times presented in the tables are measured for forward method with input size equal to 512. Other input sizes may yield slower or faster inference times. | ||
| ::: | ||
|
|
||
| | Model / Device | iPhone 17 Pro [ms] | Google Pixel 10 [ms] | | ||
| | :-------------------------------------------- | :----------------: | :------------------: | | ||
| | SSDLITE_320_MOBILENET_V3_LARGE (XNNPACK FP32) | 20 | 18 | | ||
| | SSDLITE_320_MOBILENET_V3_LARGE (Core ML FP32) | 18 | - | | ||
| | SSDLITE_320_MOBILENET_V3_LARGE (Core ML FP16) | 8 | - | | ||
| | RF_DETR_NANO (XNNPACK FP32) | TBD | TBD | | ||
| | YOLO26N (XNNPACK FP32) | TBD | TBD | | ||
| | YOLO26S (XNNPACK FP32) | TBD | TBD | | ||
| | YOLO26M (XNNPACK FP32) | TBD | TBD | | ||
| | YOLO26L (XNNPACK FP32) | TBD | TBD | | ||
| | YOLO26X (XNNPACK FP32) | TBD | TBD | | ||
|
Comment on lines
+55
to
+60
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TODO: Add times here |
||
|
|
||
| ## Style Transfer | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,11 +25,21 @@ loaded and actively running inference, relative to the baseline app memory | |
| before model initialization. | ||
| ::: | ||
|
|
||
| :::warning | ||
| Data presented for YOLO models is based on inference with forward_640 method. | ||
| ::: | ||
|
|
||
| | Model / Device | iPhone 17 Pro [MB] | Google Pixel 10 [MB] | | ||
| | --------------------------------------------- | :----------------: | :------------------: | | ||
| | SSDLITE_320_MOBILENET_V3_LARGE (XNNPACK FP32) | 94 | 104 | | ||
| | SSDLITE_320_MOBILENET_V3_LARGE (Core ML FP32) | 83 | - | | ||
| | SSDLITE_320_MOBILENET_V3_LARGE (Core ML FP16) | 62 | - | | ||
| | RF_DETR_NANO (XNNPACK FP32) | TBD | TBD | | ||
| | YOLO26N (XNNPACK FP32) | TBD | TBD | | ||
| | YOLO26S (XNNPACK FP32) | TBD | TBD | | ||
| | YOLO26M (XNNPACK FP32) | TBD | TBD | | ||
| | YOLO26L (XNNPACK FP32) | TBD | TBD | | ||
| | YOLO26X (XNNPACK FP32) | TBD | TBD | | ||
|
Comment on lines
+37
to
+42
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TODO: Add this times |
||
|
|
||
| ## Style Transfer | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.