This repository was archived by the owner on Dec 21, 2022. It is now read-only.
Convert SQL Time to ISO 8601, Safari Time Support#112
Open
ochan1 wants to merge 2 commits intosnap-cloud:masterfrom
Open
Convert SQL Time to ISO 8601, Safari Time Support#112ochan1 wants to merge 2 commits intosnap-cloud:masterfrom
ochan1 wants to merge 2 commits intosnap-cloud:masterfrom
Conversation
cycomachead
reviewed
Nov 6, 2021
Contributor
Author
|
Verified new changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safari had a problem supporting the time format outputted by the SQL Server through Lua
Safari's JavaScript interpreter for the Date class doesn't support the SQL Server format: YYYY-MM-DD HH:MM:SS-TZ:tz (where TZ:tz is Hour and Minutes of Time Zone)
We can luckily convert this time to the ISO 8601 time string format easily: YYYY-MM-DDTHH:MM:SS-TZ:tz, where "T" is between the date and time+timezone in the string
We replace the first space in the time string with "T", which is between the date and time+timezone in the string
There's no expectation for the user to modify this or any other part of the code to modify this, so the input format can be assumed to be the same