Skip to content

Comments

[chore] Remove deprecated field#1846

Merged
cedric-cordenier merged 2 commits intomainfrom
remove-deprecated-field
Feb 20, 2026
Merged

[chore] Remove deprecated field#1846
cedric-cordenier merged 2 commits intomainfrom
remove-deprecated-field

Conversation

@cedric-cordenier
Copy link
Contributor

@cedric-cordenier cedric-cordenier commented Feb 19, 2026

  • Remove EnableDeterministicPendingQueue as it's not used anymore

@github-actions
Copy link

github-actions bot commented Feb 19, 2026

⚠️ API Diff Results - Breaking changes detected

📦 Module: github-com-smartcontractkit-chainlink-common

🔴 Breaking Changes (2)

pkg/capabilities/actions/vault.(*ReportingPluginConfig) (1)
  • GetEnableDeterministicPendingQueue — 🗑️ Removed
pkg/capabilities/actions/vault.ReportingPluginConfig (1)
  • EnableDeterministicPendingQueue — 🗑️ Removed

📄 View full apidiff report

@cedric-cordenier cedric-cordenier changed the title Remove deprecated field [chore] Remove deprecated field Feb 20, 2026
@cedric-cordenier cedric-cordenier marked this pull request as ready for review February 20, 2026 14:34
@cedric-cordenier cedric-cordenier requested a review from a team as a code owner February 20, 2026 14:34
Copilot AI review requested due to automatic review settings February 20, 2026 14:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the deprecated EnableDeterministicPendingQueue field from the vault capability's protobuf configuration. The field number 8 is properly reserved to maintain backward compatibility with existing serialized data.

Changes:

  • Removed the unused EnableDeterministicPendingQueue boolean field from ReportingPluginConfig message
  • Reserved field number 8 to prevent future reuse and maintain protobuf compatibility

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pkg/capabilities/actions/vault/messages.proto Removed field definition and added reserved 8; directive
pkg/capabilities/actions/vault/messages.pb.go Removed generated Go code for the deprecated field including struct field, getter method, and protobuf descriptor data

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cedric-cordenier cedric-cordenier added this pull request to the merge queue Feb 20, 2026
Merged via the queue into main with commit bf8c838 Feb 20, 2026
39 of 40 checks passed
@cedric-cordenier cedric-cordenier deleted the remove-deprecated-field branch February 20, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants