Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Resolve non-deterministic map iteration in mode() (reduce_aggregator.go) and collectHighestCounts() (identical.go) that caused cross-node consensus failures with 'PrepareSignature failed to verify' errors.
wentzeld
had a problem deploying
to
integration
GitHub Actions
Failure
✅ API Diff Results - No breaking changes |
bolekk
requested changes
Feb 18, 2026
Contributor
bolekk
left a comment
bolekk
left a comment
There was a problem hiding this comment.
All of those are for V1 consensus, not used in CRE.
| modeKeys = append(modeKeys, sha) | ||
| } | ||
| } | ||
| sort.Slice(modeKeys, func(i, j int) bool { |
Contributor
There was a problem hiding this comment.
This file is part of V1 consensus, not used in CRE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Go map iteration order is randomized. When multiple values tie for highest frequency (mode) or equal count (identical), different nodes pick different
winners, causing PrepareSignature verification failures.
Test plan