Conversation
|
👋 yashnevatia, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
There was a problem hiding this comment.
Pull request overview
This pull request adds support for the Aptos blockchain to the chainlink-common relayer service infrastructure. The implementation follows the established patterns used for other blockchain integrations (Solana, TON, EVM) and provides comprehensive type definitions, gRPC service interfaces, and protocol buffer conversion utilities.
Changes:
- Added AptosService interface and implementation for Aptos blockchain integration
- Defined Aptos-specific types including transactions, events, view functions, and type tags
- Implemented gRPC client/server infrastructure with proto definitions and conversion helpers
- Updated mock implementations and relayer interfaces to support Aptos
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/types/chains/aptos/aptos.go | Core Aptos type definitions including Client interface, transaction types, events, and view functions |
| pkg/types/relayer.go | Added AptosService interface and Aptos() method to Relayer interface, plus UnimplementedAptosService stub |
| pkg/types/core/relayerset.go | Added Aptos() method to core Relayer interface |
| pkg/types/core/mocks/relayer.go | Generated mock implementation for Aptos() method |
| pkg/loop/mocks/relayer.go | Generated mock implementation for Aptos() method |
| pkg/loop/relayer_service.go | Added Aptos() wrapper method with service wait logic |
| pkg/loop/internal/types/types.go | Added Aptos() method to internal Relayer interface |
| pkg/loop/internal/relayer/aptos.go | gRPC client implementation for Aptos service with conversion logic |
| pkg/loop/internal/relayer/relayer.go | Integrated Aptos server registration and client initialization |
| pkg/loop/internal/relayerset/aptos.go | RelayerSet-level Aptos service implementation with client and server handlers |
| pkg/loop/internal/relayerset/client.go | Added Aptos client initialization and Aptos() method |
| pkg/loop/internal/relayerset/server.go | Registered Aptos server in RelayerSet server |
| pkg/loop/internal/relayerset/relayer.go | Added Aptos() method to relayer wrapper |
| pkg/loop/internal/pb/relayerset/helper.go | Registered Aptos server in relayer set server setup |
| pkg/loop/internal/relayer/test/relayer.go | Added stub Aptos() method to static test relayer |
| pkg/chains/aptos/aptos.proto | Protocol buffer definitions for all Aptos RPC methods and types |
| pkg/chains/aptos/aptos.pb.go | Generated protocol buffer code |
| pkg/chains/aptos/aptos_grpc.pb.go | Generated gRPC service code |
| pkg/chains/aptos/proto_helpers.go | Conversion functions between protocol buffer and Go domain types |
| pkg/chains/aptos/proto_helpers_test.go | Comprehensive tests for proto conversion functions |
| pkg/chains/aptos/generate/main.go | Code generator configuration for protobuf compilation |
| pkg/chains/aptos/generate.go | Go generate directive for proto code generation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.