Extend Trigger Capability for Event ACKing#1736
Merged
DylanTinianov merged 62 commits intomainfrom Feb 20, 2026
Merged
Conversation
|
…common into PLEX-1460-delivery-acks
bolekk
requested changes
Feb 12, 2026
bolekk
approved these changes
Feb 19, 2026
| } | ||
| } | ||
|
|
||
| func (b *BaseTriggerCapability[T]) scanPending() { |
Contributor
There was a problem hiding this comment.
cc @jmank88 for some jamming on low-level code reuse like this - we probably have many many examples where we have this kind of functionality - have a queue to process through, perform some kind of action, if not done on next loop, pickup where we were. maybe we have enough examples to package into a service?
patrickhuie19
approved these changes
Feb 20, 2026
prashantkumar1982
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends Trigger Capabilities to support trigger event ACKing.
EPIC Guaranteed Trigger Delivery
AckEventBaseTriggerCapabilityto handle event persistence, ACKing, and resending.Supports
Trigger Capability Event ACKs chainlink