Skip to content

Comments

Extend Trigger Capability for Event ACKing#1736

Merged
DylanTinianov merged 62 commits intomainfrom
PLEX-1460-delivery-acks
Feb 20, 2026
Merged

Extend Trigger Capability for Event ACKing#1736
DylanTinianov merged 62 commits intomainfrom
PLEX-1460-delivery-acks

Conversation

@DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Dec 15, 2025

Extends Trigger Capabilities to support trigger event ACKing.

EPIC Guaranteed Trigger Delivery

  • Extends Capabilities API with AckEvent
  • Implements BaseTriggerCapability to handle event persistence, ACKing, and resending.
  • Extends protos and grpc client/ server for TriggerExecutable to call AckEvent

Supports

Trigger Capability Event ACKs chainlink

@github-actions
Copy link

github-actions bot commented Dec 15, 2025

⚠️ API Diff Results - Breaking changes detected

📦 Module: github-com-smartcontractkit-chainlink-common

🔴 Breaking Changes (8)

pkg/capabilities.TriggerExecutable (1)
  • AckEvent — ➕ Added
pkg/capabilities/pb.TriggerExecutableClient (1)
  • AckEvent — ➕ Added
pkg/capabilities/v2/chain-capabilities/evm/server.ClientCapability (1)
  • AckEvent — ➕ Added
pkg/capabilities/v2/chain-capabilities/solana/server.ClientCapability (1)
  • AckEvent — ➕ Added
pkg/capabilities/v2/protoc/pkg/test_capabilities/actionandtrigger/server.BasicCapability (1)
  • AckEvent — ➕ Added
pkg/capabilities/v2/protoc/pkg/test_capabilities/basictrigger/server.BasicCapability (1)
  • AckEvent — ➕ Added
pkg/capabilities/v2/triggers/cron/server.CronCapability (1)
  • AckEvent — ➕ Added
pkg/capabilities/v2/triggers/http/server.HTTPCapability (1)
  • AckEvent — ➕ Added

📄 View full apidiff report

@DylanTinianov DylanTinianov changed the title Create BaseTriggerCapability Extend Trigger Capability API with Acks Dec 15, 2025
@DylanTinianov DylanTinianov changed the title Extend Trigger Capability API with Acks Extend Trigger Capability Dec 24, 2025
@DylanTinianov DylanTinianov changed the title Extend Trigger Capability Extend Capabilities Dec 24, 2025
}
}

func (b *BaseTriggerCapability[T]) scanPending() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @jmank88 for some jamming on low-level code reuse like this - we probably have many many examples where we have this kind of functionality - have a queue to process through, perform some kind of action, if not done on next loop, pickup where we were. maybe we have enough examples to package into a service?

@DylanTinianov DylanTinianov added this pull request to the merge queue Feb 20, 2026
Merged via the queue into main with commit bfbba3b Feb 20, 2026
34 of 36 checks passed
@DylanTinianov DylanTinianov deleted the PLEX-1460-delivery-acks branch February 20, 2026 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants