-
Notifications
You must be signed in to change notification settings - Fork 15
feat(fe): make problem statistics page #3356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
…om/skkuding/codedang into t2436-make-problem-statistics-page
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
…om/skkuding/codedang into t2436-make-problem-statistics-page
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
…om/skkuding/codedang into t2436-make-problem-statistics-page
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
| </p> | ||
| </div> | ||
| <div className="w-1/4 min-w-0 rounded-xl p-5 shadow-[0_4px_20px_0_rgba(53,78,116,0.1)]"> | ||
| <p className="text-primary text-sm font-medium tracking-[-0.42px]"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헤더 부분 모두 굵기가 400이라 font-normal로 바꿔야 될 것 같아요~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
감사합니다 수정했습니다!
| key={language.language} | ||
| > | ||
| <div className="flex items-center"> | ||
| <div className="m-2 h-1 w-1 rounded-full bg-black" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
일단 PR 늦은 것부터 사과하고 시작하겠습니다 (_ _ )
피그마 상에서는 bullet(점)이랑 언어 이름과 스코어 부분 색이 다른데 확인해주세욥!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 그러네요.. 수정했습니다!
| Correct Answers | ||
| </p> | ||
| <p className="text-2xl font-semibold tracking-[-0.72px]"> | ||
| {statistics.acceptedSubmissionCount || '-'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
피그마 상에서는 천단위 부터 쉼표 구분자를 사용하는데 그렇게 바꾸면 어떨까요? (ex. 2500 -> 2,500)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당되는 칸은 모두 구분자를 사용하도록 수정했습니다!
| {statistics.totalSubmissionCount || '-'} | ||
| </p> | ||
| </div> | ||
| <div className="w-1/4 min-w-0 rounded-xl p-5 shadow-[0_4px_20px_0_rgba(53,78,116,0.1)]"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헤더 부분이랑 수치 부분이랑 간격이 피그마보다 묘하게 좁은 것 같아요.. 전 눈이 침침해서 한번만 확인 부탁드려요~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
전 알아차리지 못했었는데 진짜로 그러네요...! 헤더에 mb-1 추가했어요~~
|
고생하셨습니다~~ 코드 너무 잘 짜셨네요.. 보면서 공부 많이 됐습니다.. |
|
❗ Syncing Preview App Failed Application: |
|
✅ Syncing Preview App Succeeded Application: |
Clover229
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 수고하셨습니다!! 강규님까지 approve 받은 후 머지하면 될 것 같아요ㅎㅎ
Description
문제 통계 페이지를 만들었습니다.
close TAS-2436
Before submitting the PR, please make sure you do the following
fixes #123).