fix(refs): Remove N^M reference checks. Fixes #56#58
fix(refs): Remove N^M reference checks. Fixes #56#58JonWolfeDrata wants to merge 1 commit intosinclairzx81:mainfrom
Conversation
|
@JonWolfeDrata Hi, Sorry for the delay on this one (have been flat out across projects lately)
The updates look good (and thanks for going across each library) but can you please just comment out the previous logic rather than remove it. As per #56
The reason is there are things downstream of this project where the previous resolver logic may be significant (although it's difficult to know without decent testing infrastructure in this project, something I haven't the bandwidth to put together at this time). I am keen on your optimizations though, but if issues do occur downstream, I would be inclined to put the old N^M logic behind a configuration option (and probably look to fix everything up at a later time). Other than that, all things look ok. Would it be possible to just comment out the previous code? |
4efbcd3 to
1c783d4
Compare
1c783d4 to
1c77c40
Compare
|
@sinclairzx81 Sorry, had a baby so wasn't at work. Updated the PR to comment out the old code and put a reference to the original issue |
Update all model-to-xxxxx that seemed affected by the N^M reference checks.
Fixes #56