-
-
Notifications
You must be signed in to change notification settings - Fork 2
Separate key terms from other training data on S3 #846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Enkidu93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Enkidu93 reviewed 10 of 10 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pmachapman)
ddaspit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddaspit reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pmachapman)
src/ServiceToolkit/src/SIL.ServiceToolkit/Services/IParallelCorpusPreprocessingService.cs line 12 at r1 (raw file):
Task PreprocessAsync( IReadOnlyList<ParallelCorpus> corpora, Func<Row, bool, Task> train,
I would prefer an enum here. It allows us to easily support more than two types of data and make it clearer what this parameter means.
c46a1eb to
9beab59
Compare
pmachapman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 6 of 11 files reviewed, 1 unresolved discussion (waiting on @ddaspit and @Enkidu93)
src/ServiceToolkit/src/SIL.ServiceToolkit/Services/IParallelCorpusPreprocessingService.cs line 12 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
I would prefer an enum here. It allows us to easily support more than two types of data and make it clearer what this parameter means.
An enum is a great idea. Please let me know if the enum and its members are named appropriately.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #846 +/- ##
==========================================
+ Coverage 66.04% 66.11% +0.06%
==========================================
Files 382 382
Lines 20635 20696 +61
Branches 2700 2706 +6
==========================================
+ Hits 13629 13683 +54
- Misses 6043 6050 +7
Partials 963 963 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddaspit reviewed 5 of 5 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pmachapman)
src/ServiceToolkit/src/SIL.ServiceToolkit/Services/IParallelCorpusPreprocessingService.cs line 12 at r1 (raw file):
Previously, pmachapman (Peter Chapman) wrote…
An enum is a great idea. Please let me know if the enum and its members are named appropriately.
Looks good.
Fixes #816. Requires sillsdev/machine.py#254
This change is