LT-22331: Pop-up Lexicon Edit pane in Interlinear view #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into LT-22093-popup
papeh
approved these changes
Dec 19, 2025
| IWfiMorphBundle bundle = m_caches.RealObject(m_hvoMorph) as IWfiMorphBundle; | ||
| if (bundle?.MorphRA?.Owner != null) | ||
| return bundle.MorphRA.Owner as ILexEntry; | ||
| return null; |
Contributor
There was a problem hiding this comment.
These three lines could be replaced with
return bundle?.MorphRA?.Owner as ILexEntry;
| private ListBox.ObjectCollection m_MGAGlossListBoxItems; | ||
|
|
||
| private Button m_btnOK; | ||
| private Button m_btnRetry; |
Contributor
There was a problem hiding this comment.
I think m_btnCreateAndEdit would be a clearer name (matching the Text rather than the DialogResult).
Src/xWorks/PopupToolWindow.cs
Outdated
| mainControl.SuspendLayout(); | ||
| m_mainContentControl = mainControl; | ||
| m_mainContentControl.Dock = DockStyle.Fill; | ||
| m_mainContentControl.AccessibleDescription = "XXXXXXXXXXXX"; |
Contributor
There was a problem hiding this comment.
If this line is necessary, contentClass would be a more useful value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements https://jira.sil.org/browse/LT-22331 based on code originally written for https://jira.sil.org/browse/LT-22093. It adds "Edit Lexical Entry..." to the sandbox combo handler to open a popup window to edit the current lexical entry. It also repurposes the retry button in InsertEntryDlg to create a new entry and then open a popup window to edit it. The Lexicon Edit Popup tool is defined in toolConfiguration.xml. PopupToolWindow implements popup tools.
This change is