Skip to content

Conversation

@jtmaxwell3
Copy link
Collaborator

@jtmaxwell3 jtmaxwell3 commented Dec 12, 2025

This fixes https://jira.sil.org/browse/LT-22313. This adds blank values to the menu of feature values. The blank value indicates that the existing value should be preserved. It uses FIllInBlanks to determine what feature structure each lexical sense should get. Since the feature structure can vary between lexical senses, the code is reorganized to get the proper Msa for each lexical sense rather than once at the beginning.


This change is Reviewable

@jasonleenaylor
Copy link
Contributor

Src/FdoUi/InflectionFeatureEditor.cs line 335 at r1 (raw file):

			int i = 0;
			//REVIEW: Should these really be the same Undo/Redo strings as for InflectionClassEditor.cs?
			m_cache.DomainDataByFlid.BeginUndoTask(FdoUiStrings.ksUndoBEInflClass, FdoUiStrings.ksRedoBEInflClass);

Since you're already touching this, the current preferred pattern for units of work is to either have a using(var helper = new UndoableUnitOfWorkHelper... or to use the UndoableUnitOfWorkHelper.Do(... method, actually, I would just use DoUsingNewOrCurrentUOW for extra safety. They provide better maintainability.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 8 of 8 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)

@jtmaxwell3 jtmaxwell3 enabled auto-merge (squash) December 12, 2025 18:50
@jtmaxwell3 jtmaxwell3 merged commit d6c1126 into release/9.3 Dec 13, 2025
4 of 5 checks passed
@jtmaxwell3 jtmaxwell3 deleted the LT-22313 branch December 13, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants