Open
Conversation
- Remove explicit undefined assignments in variable declarations - Use class name instead of 'this' in static methods - Convert value imports to type imports where appropriate - Use 'const' instead of 'let' for variables not reassigned
Prevent implicit form submission by explicitly setting button type.
Add role='button', tabIndex, and onKeyDown handler to session items in the sidebar to enable keyboard navigation with Enter and Space keys. This improves accessibility for users relying on keyboard input.
Use proper semantic HTML elements for better accessibility instead of div with role attribute.
- Rename .opencode/commands/ to .opencode/command/ - Update changelog-update.md to curate [Unreleased] section only - Enhance commit.md with detailed conventional commits guidelines
- Add type="button" to session navigation buttons in sidebar component - Ensures buttons do not accidentally submit forms if context changes - Improves code clarity and satisfies linting requirements
Biome requires braces for arrow functions in forEach callbacks to improve code consistency and readability.
Symbol.dispose should not have quotes around 'dispose'.
Prevent runtime error by throwing a clear error message if the root DOM element is not found.
Remove unused performance monitoring utilities and initialization from the web client, including the PerformanceMonitor class and web vitals tracking functionality.
Ensure urlMatch[1] exists before parsing to avoid parseInt(undefined). This fixes a potential bug where the regex might not capture the port group.
Apply Biome linting and formatting rules to the codebase, including: - Modern Node.js imports (node:path, etc.) - Template literals for string concatenation - Optional chaining for safer property access - Explicit radix for parseInt - Removal of non-null assertions where safe
Switch the lint ignore directive from ESLint to Biome syntax for the control characters regex in the stripAnsi function.
MBanucu
force-pushed
the
ci/switch-to-biome
branch
from
04cd168 to
a4b2fa9
Compare
- Split the 'quality' matrix job into individual jobs for test, typecheck, lint, format:check, and test:e2e - This allows parallel execution and clearer failure identification for each check
Replace flake.nix with devenv.nix and devenv.yaml for improved dev env management. Update .envrc to use devenv instead of flake. Adjust .gitignore to ignore devenv and direnv files. Update biome to version 2.3.13 and adjust package.json scripts.
- Update CI workflow to use devenv shell instead of nix develop - Add biome and bashInteractive packages to devenv.nix - Change nixpkgs input in devenv.yaml to nixos-unstable - Update devenv.lock accordingly
Install devenv using nix profile install nixpkgs#devenv to enable running bun commands within devenv shell environment.
Switch from format:check to format in the CI matrix to align with the transition to biome for code formatting.
Remove the strategy matrix from the nix-flake-test job and replace it with individual steps for each quality check (test, typecheck, lint, format, test:e2e). This changes the execution from parallel matrix jobs to sequential steps in a single job.
- Bump Bun version from 1.3.6 to 1.3.8 - Change nix profile install to add for devenv
- Enable JavaScript language support in devenv - Add Bun 1.3.8 via bun.enable - Remove direct bun package from packages - Add format and format:fix scripts using Biome - Remove node_modules/.bin from PATH in enterShell
Add let block to dynamically determine chromium and firefox revisions from playwright-driver.browsers.json. Include playwright-driver.browsers in packages and set PLAYWRIGHT_BROWSERS_PATH, PLAYWRIGHT_CHROMIUM_EXECUTABLE_PATH, and PLAYWRIGHT_FIREFOX_EXECUTABLE_PATH environment variables. This enables running Playwright tests in the development environment.
- Update CI workflow to run lint, format, and typecheck commands directly - Add unittest script in package.json and devenv.nix for consistency - Update test:all to use unittest instead of bun test
- Use 'unittest' script instead of 'bun test' for consistency in devenv job - Temporarily disable Magic Nix Cache (commented out)
…ting - Add AGENTS.md with comprehensive project guidelines including Biome-specific rules - Update README.md with corrected slash commands and build instructions - Include AGENTS.md in OpenCode instructions
The permission was added for FlakeHub cache authentication, but the job does not use FlakeHub. Removing to avoid granting excessive permissions.
Remove devenv scripts and update CI to call bun commands explicitly, integrating Biome for linting and formatting.
Remove the AGENTS.md file which contained detailed guidelines for agents, and update .opencode/opencode.json to remove it from the instructions array, consolidating agent instructions into README.md.
- Sort imports in test files according to biome rules - Increase timeouts in e2e tests for stability - Add NaN check in port parsing to prevent errors
- Added bun unittest command for running unit tests - Added bun test:e2e command for running end-to-end tests
Contributor
Author
|
I am done with this run. The quality of this branch is pretty good. Switch to biome finished, if you don't have any improvement suggestions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the project from ESLint and Prettier to Biome for linting and formatting.
This includes: