Update flightdata.py#9
Open
derektgardner wants to merge 1 commit intoshbisson:mainfrom
derektgardner:patch-1
Open
Update flightdata.py#9derektgardner wants to merge 1 commit intoshbisson:mainfrom derektgardner:patch-1
derektgardner wants to merge 1 commit intoshbisson:mainfrom
derektgardner:patch-1
Conversation
Added two lines at 204 and 205. I built on dump1090-fa and not piaware. OverPutney looks for "speed" in the aircraft.json file, which must be how piaware displays it. dump1090-fa uses "gs" (ground speed) instead of "speed". By adding this, both piaware and dump1090-fa users should be able to have the aircraft's speed displayed in the tweets created by OverPutney.
ladewig
added a commit
to ladewig/OverPutney
that referenced
this pull request
Aug 7, 2022
The original code is looking for "speed" in the aircraft.json file, but dump1090-fa uses "gs" (ground speed) instead. Added check for "gs" to allow speed to be reported for dump1090-fa users. This same fix was submitted to OverPutney by derektgardner (Update flightdata.py shbisson#9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two lines at 204 and 205. I built on dump1090-fa and not piaware. I wasn't getting the aircraft's speed to show up in my tweets. OverPutney looks for "speed" in the aircraft.json file, which must be how piaware displays it.
dump1090-fa uses "gs" (ground speed) instead of "speed". By adding this, both piaware and dump1090-fa users will be able to have the aircraft's speed displayed in the tweets created by OverPutney.