changed basis from char to enum#522
changed basis from char to enum#522MadhuMPandurangi wants to merge 2 commits intosfc-aqua:masterfrom
Conversation
zigen
left a comment
There was a problem hiding this comment.
thanks for contribution!
could you check my comment and fix, commit and push it again?
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MadhuMPandurangi)
quisp/modules/QNIC/StationaryQubit/StationaryQubit.cc line 253 at r1 (raw file):
if (rand < 1.0 / 3) { outcome.outcome_is_plus = qubit_ref->measureX() == EigenvalueResult::PLUS_ONE; outcome.basis = backends::abstract::Basis::X;
you can declare using backends::abstract::Basis on top of the .cc file, and use it like Basis::X.
zigen
left a comment
There was a problem hiding this comment.
and clang-format step is failed, could you run $ make format to format your code?
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MadhuMPandurangi)
|
Declaring |
zigen
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @MadhuMPandurangi)
MadhuMPandurangi
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @MadhuMPandurangi)
This is the test result. Shows successfully passed all test cases. This PR is regarding Issue #476
`[----------] Global test environment tear-down
[==========] 183 tests from 31 test suites ran. (969 ms total)
[ PASSED ] 183 tests.
make[1]: Leaving directory '/workspaces/quisp/quisp'`
This change is