feat: fallback to UIImage(named:) for custom symbol/image sets in tab…#14
Open
HaywhyD wants to merge 1 commit intoserverpod:mainfrom
Open
feat: fallback to UIImage(named:) for custom symbol/image sets in tab…#14HaywhyD wants to merge 1 commit intoserverpod:mainfrom
HaywhyD wants to merge 1 commit intoserverpod:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
UIImage(named:)fallback toCupertinoTabBarPlatformViewso thatCNTabBarcan render custom SF Symbols from the app's Xcode asset catalog, in addition to Apple's built-in SF Symbols.What changed
All 3
buildItemsfunctions inCupertinoTabBarPlatformView.swiftnow try:Non-breaking — existing code using built-in SF Symbol names works exactly as before.
Usage Guide
1. Create Custom SF Symbols
.svg2. Add to Xcode Asset Catalog
open ios/Runner.xcworkspace.svginto the asset catalog — Xcode creates a Symbol Image Set (.symbolset)my-custom-icon)3. Use in Dart
4. Naming
Use a unique prefix:
myapp-home✅,house❌ (conflicts with built-in SF Symbol)5. Android