Skip to content

Conversation

@adamrtalbot
Copy link
Contributor

@adamrtalbot adamrtalbot commented Feb 27, 2025

The heredoc for creating a k8s token was missing a namespace, or at least it didn't match the rest of the docs that focus on the tower-nf namespace. This PR adds it so that it matches up.

@netlify
Copy link

netlify bot commented Feb 27, 2025

Deploy Preview for seqera-docs ready!

Name Link
🔨 Latest commit 452c5a2
🔍 Latest deploy log https://app.netlify.com/projects/seqera-docs/deploys/697d21e6a89465000838da23
😎 Deploy Preview https://deploy-preview-492--seqera-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@gwright99
Copy link
Member

gwright99 commented Feb 27, 2025

IMO adding an explicit namespace is always a good idea.

If you don't do that, it will either end up in the default namespace (bad) or - if you have customized your kubectl context to default to another namespace - it will go there instead.

IIRC I had this discussion with docs awhile ago on another ticket and there was a deliberate decision to not include it (I dont recall the reason). I'll see if I can dig up the link.

Edit: Here's the link: #133

@adamrtalbot
Copy link
Contributor Author

If you don't do that, it will either end up in the default namespace (bad) or - if you have customized your kubectl context to default to another namespace - it will go there instead.

When I followed the instructions, I did exactly this and it took me a hot minute to work it out.

Copy link
Member

@gwright99 gwright99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my comment in the Conversation tab, this issue has been covered before and the resulting structure was a deliberate decision. Sticking to the sidelines and making no comment re: viability of this PR (despite my personal opinions).

@justinegeffen
Copy link
Contributor

Taking @gwright99's comments into account it would probably make sense to update this doc to better reflect the changes we made to the enterprise content last year. @adamrtalbot, would that work? The change is here: https://github.com/seqeralabs/docs/pull/133/files.

@justinegeffen justinegeffen requested a review from gwright99 March 16, 2025 20:59
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
@justinegeffen
Copy link
Contributor

Thanks for this, @adamrtalbot! I've implemented the suggested changes. Please could you give them a review and then I think we're good to merge. :)

Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
@justinegeffen
Copy link
Contributor

@adamrtalbot, I'm cleaning up our PR queue. Is this ready to merge? :)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪄 Pre-commit formatting suggestions

You can apply each suggestion via the GitHub UI, add a comment containing the keyword fix formatting or set up pre-commit locally and commit again.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪄 Pre-commit formatting suggestions

You can apply each suggestion via the GitHub UI, add a comment containing the keyword fix formatting or set up pre-commit locally and commit again.

justinegeffen and others added 4 commits January 29, 2026 15:54
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Justine Geffen <justinegeffen@users.noreply.github.com>
@justinegeffen justinegeffen added 1. Dev/PM/SME Needs a review by a Dev/PM/SME additional work req. Additional work is required/comments need to be addressed before second review content-improvement This work improves content editorially or structurally. labels Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1. Dev/PM/SME Needs a review by a Dev/PM/SME additional work req. Additional work is required/comments need to be addressed before second review content-improvement This work improves content editorially or structurally.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants