Skip to content

Conversation

@yzang2019
Copy link
Contributor

Describe your changes and provide context

Resolve VERSION from branch or tag:

  • Extract vX.Y.Z (+ any suffix) from the branch name when present.
  • Compare only the base vX.Y.Z (strip any suffix) between branch/tag.
  • Prefer tag if bases are equal; otherwise use whichever base is newer.

Testing performed to validate your change

Tested with a few existing release branches

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJan 27, 2026, 4:37 PM

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.88%. Comparing base (d2b43d3) to head (c072100).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2752      +/-   ##
==========================================
+ Coverage   52.41%   56.88%   +4.47%     
==========================================
  Files        1022     2004     +982     
  Lines       84800   164703   +79903     
==========================================
+ Hits        44446    93695   +49249     
- Misses      36226    62783   +26557     
- Partials     4128     8225    +4097     
Flag Coverage Δ
sei-chain 41.74% <ø> (?)
sei-cosmos 48.12% <ø> (-0.01%) ⬇️
sei-db 68.72% <ø> (ø)
sei-tendermint 58.52% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1144 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

* main:
  Fix workflow dispatch for libwasmvm job (#2727)
  feat: deflake TestMConnectionReadErrorUnknownChannel (#2750)
  Add go generate script to download evmone libraries on the fly (#2744)
  [giga] Add UseRegularStore flag to GigaEvmKeeper for testing fallback (#2745)
  [giga] Add toEvmcError() for Go to EVMC error conversion (#2743)
* main:
  Add go bench for sc commit store (#2731)
@yzang2019 yzang2019 changed the title Improve make file version tag logic Fix seid version tagging logic for release branch Jan 27, 2026
@yzang2019 yzang2019 enabled auto-merge (squash) January 27, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants