-
Notifications
You must be signed in to change notification settings - Fork 16
Add basic support for user-defined presets storing in localStorage #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MelanX
wants to merge
14
commits into
sebinside:main
Choose a base branch
from
MelanX:feature/user-preset-manager
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Should work as expected now. |
Owner
|
After we have URL encoding with #351, this feature is not that critical anymore. I will delay it for now until the next UI redesign to keep things simple. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the basic functionality for saving and loading custom setting presets. Presets will be stored in
localStoragewith keyiconPresetsas JSON.There are two buttons for opening dialogs for more actions:

The loading button would be grayed out when no preset is existing. The number in the brackets shows the amount of available presets.
There's a dialog when saving:

There's a dialog when loading:

Related issue: #283
Known issue
PresetOptions.vueAll in all, this pull request really adds just a starting point for the preset settings.