simple_forward: Validate destination argument (-d)#339
Open
harshraj1695 wants to merge 1 commit intosdnfv:developfrom
Open
simple_forward: Validate destination argument (-d)#339harshraj1695 wants to merge 1 commit intosdnfv:developfrom
harshraj1695 wants to merge 1 commit intosdnfv:developfrom
Conversation
Member
|
Thanks for your contribution @harshraj1695 ! This looks like a reasonable fix. Please update the indentation to match the style of the rest of the code and we will accept your change. |
Previously, the -d argument was parsed without validating the input. This could lead to unintended behavior when non-numeric values were provided, silently defaulting to 0. This patch adds proper validation to ensure only valid numeric service IDs are accepted. Tested by running NF with valid and invalid -d values.
harshraj1695
force-pushed
the
fix-validate-destination
branch
from
71376c4 to
c065e4b
Compare
Author
|
Added braces for proper scoping under case 'd' and fixed indentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Previously, the -d argument was parsed without validating the input.
This could lead to unintended behavior when non-numeric values were
provided, silently defaulting to 0.
Solution
Added validation to ensure only valid numeric service IDs are accepted.
Test Plan