[FEATURE, BREAKING] Support for extensible-format WAVE files#19
Merged
sdatkinson merged 5 commits intomainfrom May 10, 2025
Merged
[FEATURE, BREAKING] Support for extensible-format WAVE files#19sdatkinson merged 5 commits intomainfrom
sdatkinson merged 5 commits intomainfrom
Conversation
Owner
Author
|
Looks like the build is broken. I'll get that later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking because the error codes are now different--remove "no support for extensible", add a miscellaneous "no support" in case a compressed format is encountered.
Tested by using in NeuralAmpModelerPlugin with this IR, which wasn't supported before. The results using a re-rendered version of the file in the plugin's IR loader produces identical results to the new code with the original file.
Resolves #5.