Skip to content

Conversation

@dkropachev
Copy link
Collaborator

@dkropachev dkropachev commented Jan 30, 2026

Summary

The skip decorators were redundant because:

  1. test_control_connection_port_discovery: Already has @greaterthanorequalcass40 which skips for Scylla (mapped to Cassandra 3.11.4)
  2. test_single_interface: The entire SingleInterfaceTest class has @greaterthanorequalcass40
  3. test_host_addresses: Port assertions are conditional on CASSANDRA_VERSION >= Version('4-a')

Since Scylla's CASSANDRA_VERSION defaults to 3.11.4 (via MAPPED_SCYLLA_VERSION), these version checks already prevent the port-related assertions from running on Scylla clusters.

Additionally, the listen_address assertion in test_host_addresses is now skipped for Scylla since Scylla doesn't populate this field in its system.local table.

Test plan

  • Run integration tests against Scylla to verify tests pass
  • Run integration tests against Cassandra 4.0+ to verify port discovery works

Fixes #121

The skip decorators referencing issue #121 were unnecessary because:

- test_control_connection_port_discovery: Already has @greaterthanorequalcass40
  which skips for Scylla (mapped to Cassandra 3.11.4)
- test_single_interface: The entire class has @greaterthanorequalcass40
- test_host_addresses: Port assertions are conditional on CASSANDRA_VERSION >= 4.0

Since Scylla's CASSANDRA_VERSION defaults to 3.11.4, these version checks
already prevent the port-related assertions from running on Scylla.

Fixes: #121
@dkropachev dkropachev force-pushed the fix/issue-121-remove-redundant-skips branch from f9bb1e1 to e2144a2 Compare January 30, 2026 15:44
@dkropachev dkropachev merged commit 5763a9d into master Jan 31, 2026
25 checks passed
@dkropachev dkropachev deleted the fix/issue-121-remove-redundant-skips branch January 31, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Host metadata broadcast_rpc_port is None

3 participants