Specify protocol version for cluster to use #669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this on cluster lvl we assumed protocol version is 4, even if it was 3. Test `test_imprecise_bind_values_dicts` rely on protocol specific behavior and was failing for v3.
dkropachev
approved these changes
Jan 30, 2026
sylwiaszunejko
added a commit
to sylwiaszunejko/python-driver-matrix
that referenced
this pull request
Jan 30, 2026
To propagate fix from scylladb/python-driver#669
This was referenced Jan 30, 2026
|
We should remove protocol v3 support. No one needs it. |
Maybe it should be removed from the server first in that case? |
Why does it matter? It's a tech debt in both sides. |
Are there no tests on Scylla side using protocol 3? One side (Driver or server) will need to be changed first. If we change driver, this will break any protocol 3 tests on server side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this on cluster lvl we assumed protocol version is 4, even if it was 3. Test
test_imprecise_bind_values_dictsrely on protocol specific behavior and was failing for v3.