-
Notifications
You must be signed in to change notification settings - Fork 50
Fix test_client_routes_change_event #656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test_client_routes_change_event #656
Conversation
dc737f8 to
55a05fd
Compare
|
@Lorak-mmk There is some problem with this test, it uses |
| runs-on: ubuntu-24.04 | ||
| env: | ||
| SCYLLA_VERSION: release:2025.2 | ||
| SCYLLA_VERSION: release:2026.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not released yet...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my mistake, I saw it on driver matrix and locally with this setting I was able to successfully run this test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the first version that supports CLIENT_ROUTES_CHANGE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, it is 2026.1.0, so we need to use it at least for testing purposes in the PR, and remove the commit that bums the scylla version, before the merge, is that ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just run this test locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
locally it works just fine
| runs-on: ubuntu-24.04 | ||
| env: | ||
| SCYLLA_VERSION: release:2025.2 | ||
| SCYLLA_VERSION: release:2026.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just run this test locally
55a05fd to
8adfac8
Compare
|
@dkropachev please take a look |
8adfac8 to
72eb00d
Compare
Bumped SCYLLA_VERSION to verify that the test is working as expected.
Fixes: #652