-
Notifications
You must be signed in to change notification settings - Fork 7
feat: enable legacy state root tree by default #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
yiweichi
commented
Jan 11, 2026
frisitano
requested changes
Jan 12, 2026
Collaborator
frisitano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove rust-toolchain.toml and update the Makefile:
NIGHTLY_TOOLCHAIN := nightly-2026-01-05
.PHONY: fmt
fmt:
cargo +$(NIGHTLY_TOOLCHAIN) fmt
.PHONY: lint-toml
lint-toml: ensure-dprint
dprint fmt
ensure-dprint:
@if ! command -v dprint &> /dev/null; then \
echo "dprint not found. Please install it by running the command `cargo install --locked dprint` or refer to the following link for more information: https://github.com/dprint/dprint" \
exit 1; \
fi
.PHONY: clippy
clippy:
cargo +$(NIGHTLY_TOOLCHAIN) clippy \
--workspace \
--lib \
--examples \
--tests \
--benches \
--all-features \
-- -D warnings
.PHONY: clippy-fix
clippy-fix:
cargo +$(NIGHTLY_TOOLCHAIN) clippy \
--workspace \
--lib \
--examples \
--tests \
--benches \
--all-features \
--fix \
-- -D warnings
.PHONY: udeps
udeps:
cargo +$(NIGHTLY_TOOLCHAIN) udeps --workspace --lib --examples --tests --benches --all-features --locked
frisitano
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables reth to use legacy state root tree by default.
Fixes #468