fix: improve worker validation, scheduling docs, and pipeline state consistency#31
Open
sidbhagat05 wants to merge 1 commit intoscripbox:masterfrom
Conversation
…onsistency - Added Support for Redis Sentinel #Issue 21 - Moved Config options to Flume.supervisor #Issue 22 - Added telemetry for producer, producer_consumer & consumer #Issue 29 - Used Logger Library and remved Flume.Logger and Flume.DefaultLogger #Issue 17 - Add JobValidator module for proper worker function validation #Issue 19 - Update README scheduling documentation to use unix timestamps instead of misleading milliseconds #Issue 24 - Rename enqueue_in parameter from time_in_seconds to unix_time_in_seconds for clarity #Issue 24 - Fix pipeline pause/resume bug where Redis state was inconsistent on GenStage failures #Issue 11 - Fix incorrect typespec annotations in Flume module (pause_all/resume_all) #Issue 11 - Improve test coverage and fix compatibility issues Resolves: worker validation errors, scheduling documentation confusion, pipeline state bugs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses three critical issues in the Flume job processing system:
🔧 Fixes Included:
Worker Validation Improvements
time_in_seconds→unix_time_in_secondsfor clarityFlume.ex,DefaultAPI,Manager,MockAPIBefore:
After:
Pipeline State Consistency Bug Fix
-Fixed race condition: Pipeline pause/resume operations now only update Redis state AFTER successful GenStage operations
-Prevents inconsistent state: Previously Redis keys were set/deleted before GenStage calls, causing state mismatches on failures
-upgraded elixir version to 1.18.4
-Fixed incorrect typespec annotations in
Flume.ex(pause_all/resume_all functions)-Clean compilation with no warning
🧪 Testing
📈 Impact
Consistent state prevents production issues