Skip to content

Fix: Conjugation view resets on arrow navigation#579

Open
mtiwari479 wants to merge 1 commit intoscribe-org:mainfrom
mtiwari479:fix-conjugation-navigation
Open

Fix: Conjugation view resets on arrow navigation#579
mtiwari479 wants to merge 1 commit intoscribe-org:mainfrom
mtiwari479:fix-conjugation-navigation

Conversation

@mtiwari479
Copy link

Fix: Conjugation view resets on arrow navigation

Issue:
Left/right arrow navigation in the conjugation view resets the keyboard to the default alphabetical layout instead of cycling through tenses.

Root Cause:
Arrow buttons in KeyboardUIManager.kt were calling onConjugateClicked(), which triggered a full UI refresh and reset the keyboard state.

Fix:
Replaced onConjugateClicked() with refreshUIForConjugation() to preserve the current state while updating the conjugation index.
Additionally, ensured navigation events are handled properly without triggering unintended state resets.

Files Changed:
KeyboardUIManager.kt: Updated arrow button click handling to prevent UI reset
KeyHandler.kt: Ensured navigation keys are properly handled and consumed
GeneralKeyboardIME.kt: Prevented unintended state reset during navigation

Testing:

  • Tested with verbs such as manger, aller
  • Verified navigation between tenses
  • Tested rapid arrow clicks
  • Confirmed no keyboard reset occurs

Screenshots:
1. Conjugation entry
Entry

2. Initial tense (Futur)
Futur

3. After navigation (Passé simple)
Passe simple

Result:
Conjugation view remains active and correctly cycles through tenses using arrow buttons.

Related Issue:
#549

@github-actions
Copy link

Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
    - The contributor's name and icon in remote commits should be the same as what appears in the PR
    - If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo (can be set with git config --global user.email "GITHUB_EMAIL")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant