Fix: Conjugation view resets on arrow navigation#579
Fix: Conjugation view resets on arrow navigation#579mtiwari479 wants to merge 1 commit intoscribe-org:mainfrom
Conversation
Thank you for the pull request! 💙The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
There was a problem hiding this comment.
First PR Commit Check
- The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have forgit config user.emailin their local Scribe-Android repo (can be set withgit config --global user.email "GITHUB_EMAIL")
Fix: Conjugation view resets on arrow navigation
Issue:
Left/right arrow navigation in the conjugation view resets the keyboard to the default alphabetical layout instead of cycling through tenses.
Root Cause:
Arrow buttons in
KeyboardUIManager.ktwere callingonConjugateClicked(), which triggered a full UI refresh and reset the keyboard state.Fix:
Replaced
onConjugateClicked()withrefreshUIForConjugation()to preserve the current state while updating the conjugation index.Additionally, ensured navigation events are handled properly without triggering unintended state resets.
Files Changed:
KeyboardUIManager.kt: Updated arrow button click handling to prevent UI resetKeyHandler.kt: Ensured navigation keys are properly handled and consumedGeneralKeyboardIME.kt: Prevented unintended state reset during navigationTesting:
manger,allerScreenshots:

1. Conjugation entry
2. Initial tense (Futur)

3. After navigation (Passé simple)

Result:
Conjugation view remains active and correctly cycles through tenses using arrow buttons.
Related Issue:
#549