fix: resolve minor color inconsistencies in app and keyboard UI (#543)#578
fix: resolve minor color inconsistencies in app and keyboard UI (#543)#578ashb155 wants to merge 8 commits intoscribe-org:mainfrom
Conversation
- dynamic system bars and disabled contrast enforcement
Thank you for the pull request! 💙The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
There was a problem hiding this comment.
First PR Commit Check
- The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have forgit config user.emailin their local Scribe-Android repo (can be set withgit config --global user.email "GITHUB_EMAIL")
Contributor checklist
./gradlew lintKotlin detekt testcommand...Description
This PR resolves all UI and color inconsistencies in Issue #543 by fixing the bottom navigation bar to match the app theme in 3-button and gesture navigation modes, removing hardcoded grey backgrounds from the conjugation grid, and ensuring all keyboard and conjugation view elements correctly follow the app's Light/Dark mode.
Changes included:
Spacertied toWindowInsets.navigationBarsinScribeBottomBar.ktto paint the surface color behind the navigation bar.applyNavigationBarStyleusingenableEdgeToEdge()inMainActivity.ktto dynamically sync the system navigation bar icon colors with the app's Light/Dark mode.conjugate_gridXML layouts, replacing them with@android:color/transparent.KeyboardUIManager.ktto dynamically applydark_key_colorandlight_key_colorto the Conjugation grid buttons.Screenshots
1. App Navigation Bar - 3-button navigation
2. App Navigation Bar - Gesture navigation
3. Keyboard - 3-button navigation
4. Keyboard - Gesture navigation
5. Conjugation Grid - 3-button navigation
6. Conjugation Grid - Gesture navigation
Related issue