Skip to content

fix: resolve minor color inconsistencies in app and keyboard UI (#543)#578

Open
ashb155 wants to merge 8 commits intoscribe-org:mainfrom
ashb155:fix-color-inconsistencies
Open

fix: resolve minor color inconsistencies in app and keyboard UI (#543)#578
ashb155 wants to merge 8 commits intoscribe-org:mainfrom
ashb155:fix-color-inconsistencies

Conversation

@ashb155
Copy link

@ashb155 ashb155 commented Mar 22, 2026

Contributor checklist

  • This pull request is on a separate branch and not the main branch
  • I have tested my code with the ./gradlew lintKotlin detekt test command...

Description

This PR resolves all UI and color inconsistencies in Issue #543 by fixing the bottom navigation bar to match the app theme in 3-button and gesture navigation modes, removing hardcoded grey backgrounds from the conjugation grid, and ensuring all keyboard and conjugation view elements correctly follow the app's Light/Dark mode.

Changes included:

  • App Navigation Bar : Added a Spacer tied to WindowInsets.navigationBars in ScribeBottomBar.kt to paint the surface color behind the navigation bar.
  • Edge-to-Edge Support : Implemented applyNavigationBarStyle using enableEdgeToEdge() in MainActivity.kt to dynamically sync the system navigation bar icon colors with the app's Light/Dark mode.
  • Transparent Grids : Removed hardcoded grey backgrounds from all conjugate_grid XML layouts, replacing them with @android:color/transparent.
  • Themed Verb Buttons : Updated KeyboardUIManager.kt to dynamically apply dark_key_color and light_key_color to the Conjugation grid buttons.

Screenshots

1. App Navigation Bar - 3-button navigation

Light Mode Dark Mode
Screenshot 2026-03-22 170504 Screenshot 2026-03-22 170545

2. App Navigation Bar - Gesture navigation

Light Mode Dark Mode
Screenshot 2026-03-22 171237 Screenshot 2026-03-22 171227

3. Keyboard - 3-button navigation

Light Mode Dark Mode
Screenshot 2026-03-22 170701 Screenshot 2026-03-22 170628

4. Keyboard - Gesture navigation

Light Mode Dark Mode
Screenshot 2026-03-22 171259 Screenshot 2026-03-22 171142

5. Conjugation Grid - 3-button navigation

Light Mode Dark Mode
Screenshot 2026-03-22 170813 Screenshot 2026-03-22 170918

6. Conjugation Grid - Gesture navigation

Light Mode Dark Mode
Screenshot 2026-03-22 171313 Screenshot 2026-03-22 171200

Related issue

@github-actions
Copy link

Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
    - The contributor's name and icon in remote commits should be the same as what appears in the PR
    - If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo (can be set with git config --global user.email "GITHUB_EMAIL")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minor Color Inconsistencies in App and Keyboard UI

1 participant