Refactors the bottom tab bar navigation to improve modularity and maintainability.#576
Conversation
Thank you for the pull request! 💙The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
Thanks for the PR, @Femimat! Can you look into the license header errors? :) |
|
Sure I will look into it @andrewtavis |
81eadd9 to
dfc1f05
Compare
angrezichatterbox
left a comment
There was a problem hiding this comment.
Thanks for your PR @Femimat. Great Work 🎉. I have made a slight change of using BuildConfig instead of using a bool for switching between the apps.
dfc1f05 to
bc7cd36
Compare
andrewtavis
left a comment
There was a problem hiding this comment.
Thanks from my end as well, @Femimat! All's looking great here as well 😊
4b14e7e to
57e820c
Compare
57e820c to
46c40f2
Compare
|
Thanks, @angrezichatterbox! That’s a much better approach for handling environment switches; using BuildConfig definitely feels more robust for these flags. I'll make sure to prioritize that pattern moving forward. Also, thanks for the review and the help, @andrewtavis! |
… tests
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
Refactors the bottom tab bar navigation to improve modularity and maintainability.
Main changes:
ScribeBottomBar.kt&BottomBarScreen.kt— Adjusted bottom bar views.Screen.kt— Modified screens so they could better fit with tab bar.MainActivity.kt(conjugate & keyboards flavors) — Got both flavors working with new nav changes.App.kt— Made changes to app setup to work with new nav stuff.bools.xml(main & conjugate flavor) — Changed some booleans used by the bottom barTesting:
Added
BottomBarScreenTest.ktwith unit tests covering the refactored bottom bar screen logicVerified with
./gradlew lintKotlin detekt testRefactor the tab bar component to be used in both the keyboard and conjugation apps #560