Skip to content

Refactors the bottom tab bar navigation to improve modularity and maintainability.#576

Merged
andrewtavis merged 4 commits intoscribe-org:mainfrom
Femimat:feature/refactor-tab-bar-560
Mar 23, 2026
Merged

Refactors the bottom tab bar navigation to improve modularity and maintainability.#576
andrewtavis merged 4 commits intoscribe-org:mainfrom
Femimat:feature/refactor-tab-bar-560

Conversation

@Femimat
Copy link
Contributor

@Femimat Femimat commented Mar 21, 2026

… tests

Contributor checklist


Description

Refactors the bottom tab bar navigation to improve modularity and maintainability.

Main changes:

  • ScribeBottomBar.kt & BottomBarScreen.kt — Adjusted bottom bar views.
  • Screen.kt — Modified screens so they could better fit with tab bar.
  • MainActivity.kt (conjugate & keyboards flavors) — Got both flavors working with new nav changes.
  • App.kt — Made changes to app setup to work with new nav stuff.
  • bools.xml (main & conjugate flavor) — Changed some booleans used by the bottom bar

Testing:

@github-actions
Copy link

Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

github-actions bot commented Mar 21, 2026

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@Femimat Femimat changed the title refactor(nav): restructure tab bar components and add BottomBarScreen… Refactors the bottom tab bar navigation to improve modularity and maintainability. Mar 21, 2026
@andrewtavis
Copy link
Member

Thanks for the PR, @Femimat! Can you look into the license header errors? :)

@Femimat
Copy link
Contributor Author

Femimat commented Mar 21, 2026

Sure I will look into it @andrewtavis

@angrezichatterbox angrezichatterbox force-pushed the feature/refactor-tab-bar-560 branch from 81eadd9 to dfc1f05 Compare March 23, 2026 15:29
Copy link
Member

@angrezichatterbox angrezichatterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @Femimat. Great Work 🎉. I have made a slight change of using BuildConfig instead of using a bool for switching between the apps.

@angrezichatterbox angrezichatterbox force-pushed the feature/refactor-tab-bar-560 branch from dfc1f05 to bc7cd36 Compare March 23, 2026 15:32
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks from my end as well, @Femimat! All's looking great here as well 😊

@angrezichatterbox angrezichatterbox force-pushed the feature/refactor-tab-bar-560 branch 2 times, most recently from 4b14e7e to 57e820c Compare March 23, 2026 15:45
@angrezichatterbox angrezichatterbox force-pushed the feature/refactor-tab-bar-560 branch from 57e820c to 46c40f2 Compare March 23, 2026 15:54
@Femimat
Copy link
Contributor Author

Femimat commented Mar 23, 2026

Thanks, @angrezichatterbox! That’s a much better approach for handling environment switches; using BuildConfig definitely feels more robust for these flags. I'll make sure to prioritize that pattern moving forward.

Also, thanks for the review and the help, @andrewtavis!

@andrewtavis andrewtavis merged commit 622961e into scribe-org:main Mar 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants